GeoJSON functions #301
GeoJSON functions #301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 18 18
Lines 389 513 +124
==========================================
+ Hits 389 513 +124 ☔ View full report in Codecov by Sentry. |
* Remove geojson logic from cell_to_boundary and directed_edge_to_boundary * fix a warning about return values in tests from pytest * Remove geo_json logic from cells_to_multi_polygon * remove some unused tests * add back in polygons_to_cells
| @@ -19,7 +19,7 @@ on: | |||
|
|
|||
| jobs: | |||
| make_sdist: | |||
| name: "SDist: ${{ matrix.os }}" | |||
| name: 'SDist: ${{ matrix.os }}' | |||
There was a problem hiding this comment.
Were the quotes changed by a yaml formatter? If not I would recommend having this enforced by formatted rather than manual changes
.github/workflows/tests.yml
Outdated
| exclude: | ||
| - os: windows-latest | ||
| python-version: 3.5 | ||
| python-version: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11'] |
There was a problem hiding this comment.
Python 3.12 released recently, btw. But it may also be worth doing that in a different PR because they finally killed some deprecated features of setup.py and I don't know if we're impacted by any of them.
There was a problem hiding this comment.
(So, maybe add '3.12' to this PR, but if it fails, roll it back and we dig into it in a follow-up PR?)
There was a problem hiding this comment.
I'm anticipating some work to figure out the changes with 3.12, which will also involve updating the wheels matrix. I'd rather just do all the 3.12 work together in a separate PR.
|
Here's a rendered version of the tutorial notebook: https://gist.github.com/ajfriend/0b7de6153acdd6a1ca04cd9033285beb I'm still not sure if I'll leave this as a notebook, or work it into the documentation website. |
|
cc: @DahnJ, your feedback would be very valuable, since there's a lot here that would relate to https://github.com/DahnJ/H3-Pandas |
Co-authored-by: Jongbin Jung <[email protected]>
Co-authored-by: Isaac Brodsky <[email protected]>
Co-authored-by: Jongbin Jung <[email protected]>
No description provided.