-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose cython API for external use #234
Expose cython API for external use #234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 425 425
=========================================
Hits 425 425 Continue to review full report at Codecov.
|
Ah the test script in cibuildwheel needs to be updated to either ignore the Cython test or compile the cython file used in that test. |
I updated to ignore the test when the cython example wasn't compiled |
Sweeeeeeet! |
Really simple notebook example for future reference: https://gist.github.com/ajfriend/167afffde74bc08b0e809e10b92ecde3 |
Change list
CMakeLists.txt
to include.pyx
and.pxd
files in distribution after skbuild is done processingh3api.h
in final bundle. This can usually be found automatically when compiling, but if we have issues with this in the future, we can emulate Numpy and itsnp.get_include
function.Closes #152