Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group history fields #694

Open
wants to merge 7 commits into
base: release/4.0.0
Choose a base branch
from
Open

Group history fields #694

wants to merge 7 commits into from

Conversation

adhityamamallan
Copy link
Contributor

@adhityamamallan adhityamamallan commented Oct 15, 2024 •
edited
Loading

Summary

  • Modify history event details generation to maintain object hierarchy instead of fully flattening everything down to one level
    • We add a Details Entry type for grouped Details Entries
  • Create WorkflowHistoryEventDetailsRecursive component that recursively renders the grouped details
  • Create WorkflowHistoryEventDetailsBaseValue as the base case for this recursive rendering

Test plan

Unit tests + ran cadence-web locally.

Objects
Screenshot 2024-10-16 at 2 30 04 PM

Arrays
Screenshot 2024-10-16 at 10 55 33 AM

@adhityamamallan adhityamamallan marked this pull request as ready for review October 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assem-Uber Assem-Uber Assem-Uber left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhityamamallan @Assem-Uber