Error prone DoNotMock annotation added to elements with test helpers #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangarharshit
changed the title
ZacSweers
approved these changes
Dec 31, 2017
|
Forgot we have an internal implementation of the donotmock checker. Oh well, will take effect when someone implements one anyway. |
|
Not sure what's up with the CLA check. Will give it a bit to resolve itself |
|
CLA check seems to be stuck. It may need a retry |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements with test helpers shouldn't be mocked as it can break during an update. Use Test helpers instead. Fixes - #146
The annotation is currently just an indication to developer as the relevant check to enforce this is not yet open sourced - google/error-prone#572