Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error-prone DoNotMock annotations to elements with test helpers #146

Closed
ZacSweers opened this issue Dec 5, 2017 · 3 comments
Closed

Add error-prone DoNotMock annotations to elements with test helpers #146

ZacSweers opened this issue Dec 5, 2017 · 3 comments
Labels
Enhancement Help wanted Test
Milestone
0.6.0

Comments

@ZacSweers
Copy link
Collaborator

After fixing a bunch of cases where bad mockito usage broke tests during the last update, I think we should introduce these.

Anything with a test component should get this annotation and point to its test component.

  • ScopeProvider -> TestScopeProvider
  • LifecycleScopeProvider -> TestLifecycleScopeProvider

The error-prone annotations themselves should be compileOnly or provided
@ZacSweers ZacSweers added this to the 0.6.0 milestone Dec 5, 2017
@bangarharshit
Copy link
Contributor

I can work on it. Do you also expect positive/negative test cases?

@ZacSweers
Copy link
Collaborator Author

No need for tests, just the annotations will do

@bangarharshit bangarharshit mentioned this issue Dec 31, 2017
Merged
@ZacSweers
Copy link
Collaborator Author

Done in #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Help wanted Test
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@ZacSweers @bangarharshit