Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Error Prone 2.27.1 #957

Merged
merged 1 commit into from
May 17, 2024
Merged

Update to Error Prone 2.27.1 #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ jobs:
epVersion: 2.10.0
- os: macos-latest
java: 11
epVersion: 2.26.1
epVersion: 2.27.1
- os: ubuntu-latest
java: 11
epVersion: 2.26.1
epVersion: 2.27.1
- os: windows-latest
java: 11
epVersion: 2.26.1
epVersion: 2.27.1
- os: ubuntu-latest
java: 17
epVersion: 2.26.1
epVersion: 2.27.1
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
with:
arguments: codeCoverageReport
continue-on-error: true
if: runner.os == 'Linux' && matrix.java == '11' && matrix.epVersion == '2.26.1' && github.repository == 'uber/NullAway'
if: runner.os == 'Linux' && matrix.java == '11' && matrix.epVersion == '2.27.1' && github.repository == 'uber/NullAway'
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import org.gradle.util.VersionNumber
// The oldest version of Error Prone that we support running on
def oldestErrorProneVersion = "2.10.0"
// Latest released Error Prone version that we've tested with
def latestErrorProneVersion = "2.26.1"
def latestErrorProneVersion = "2.27.1"
// Default to using latest tested Error Prone version
def defaultErrorProneVersion = latestErrorProneVersion
def errorProneVersionToCompileAgainst = defaultErrorProneVersion
Expand Down
2 changes: 1 addition & 1 deletion nullaway/src/main/java/com/uber/nullaway/dataflow/cfg/NullAwayCFGBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public <R, D> R accept(TreeVisitor<R, D> visitor, D data) {

@Override
public MethodInvocationNode visitMethodInvocation(MethodInvocationTree tree, Void p) {
MethodInvocationNode originalNode = super.visitMethodInvocation(tree, p);
MethodInvocationNode originalNode = super.visitMethodInvocation(tree, null);
return handler.onCFGBuildPhase1AfterVisitMethodInvocation(this, tree, originalNode);
}
}
Expand Down
2 changes: 1 addition & 1 deletion nullaway/src/main/java/com/uber/nullaway/handlers/contract/ContractCheckHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public Void visitReturn(ReturnTree returnTree, Void unused) {
returnState,
null));
}
return super.visitReturn(returnTree, unused);
return super.visitReturn(returnTree, null);
}
}.scan(state.getPath(), null);
}
Expand Down
Loading