Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dereference of qualifier expression in method reference #920

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Check dereference of qualifier expression in method reference #920

merged 2 commits into from
Feb 23, 2024

Conversation

msridhar
Copy link
Collaborator

Fixes #919

@msridhar msridhar requested a review from yuxincs February 23, 2024 18:15
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (3fc9b8a) to head (48d50e9).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #920      +/-   ##
============================================
+ Coverage     86.98%   87.09%   +0.10%     
- Complexity     1959     1990      +31     
============================================
  Files            77       77              
  Lines          6330     6430     +100     
  Branches       1223     1245      +22     
============================================
+ Hits           5506     5600      +94     
- Misses          420      422       +2     
- Partials        404      408       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuxincs
yuxincs approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix!

@msridhar msridhar merged commit a7bb7d3 into uber:master Feb 23, 2024
12 checks passed
@msridhar msridhar deleted the issue-919 branch February 23, 2024 18:56
@msridhar msridhar mentioned this pull request Mar 3, 2024
Merged
msridhar added a commit that referenced this pull request Mar 4, 2024
@msridhar
Fix handling of references to methods of array types and type variabl…
348bb4d 
…es (#926)

After #920 we check the nullability of the qualifier expression of a
method reference. We weren't correctly handling the cases where that
expression was an array type or a type variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxincs yuxincs yuxincs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method references of nullable instances are not detected
2 participants
@msridhar @yuxincs