Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GCP JMH Benchmark Workflow #770
Added GCP JMH Benchmark Workflow #770
Changes from 171 commits
1fe54cc
63d30d7
3afb61f
a613e2a
e406cb6
a222600
26b8048
e5372ef
0736aaf
ba562c0
9a43532
e48a6e4
7b3aa41
a35945b
d4524a0
53c4b81
6bfdfac
eb05c20
3afdb82
b6d16c8
04f34ab
f8ed394
4f616e4
b8bdf4a
500371f
4cbcf34
d58429e
7ed8ec3
f3ced35
813b9b2
5ff6fe3
3615ccf
5e15f52
f3720f0
82590a7
eccf9db
652821c
358b2a1
21b0796
0609fd7
1bdc013
90dde3c
9fcbb53
e78df0b
a9b007c
a1173ab
770a938
d101171
7234311
517d3b4
4164312
5b54988
c86f354
3d1d4b0
998bf7a
f6a3753
e9cb3c6
712c96f
5125f9f
35c9fde
21a7963
7abaf9b
69f45d3
2acc459
319ae4c
da7fa8d
1290374
0c95cb5
84c84c6
b12ff25
162a88f
b8aec1e
c70309e
3a2f46d
db5142a
d259743
f715219
f60a648
2e65279
72f5997
500ec84
410a576
2e104d2
72b9375
52d73cb
14b84e7
ee0b3ed
2728189
0058466
0b9a868
a2b34ad
9ea4bef
5578feb
28b8ab0
f6595d7
2b9e337
1d890a6
827471c
69b1706
1ccaaee
f35a679
7051379
3df2372
8b26c84
04e1b4f
b1d328c
f6b384a
750ed82
fd1e993
78a0ca6
7c7ae0b
9d5008a
3dd23da
ee97fa2
60f40c0
a180681
21fa635
a22dd49
3670482
859a079
0af9dee
c9cf2b0
24d527b
059cbcf
d51e45f
860ad36
9cded48
619176a
4e6665e
9c11cd2
b7f6478
b552753
97a664d
4f6df5c
e4916be
bffefdb
6c752c6
d6e832f
2547993
976df47
9a41a4c
0e6a13f
010843e
041f2b8
d0e89d2
f2acee0
11b65c9
7de9274
a1c9b50
9b99d3a
730a6c9
2e472d4
2dd58e6
97ae313
90f1cb1
64c70a6
8a865bb
cf95913
21c030c
95eb12e
ca7f20c
12d16de
1c4681d
16231f5
52f94ca
03b47b2
75c6ca9
dc7588b
092ed4d
828a29d
006c624
b150f9b
a0b77f0
c9632de
1d1b050
5d32846
1b07f0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this
cd $BRANCH_NAME/
command in this script and alsorun_pr_benchmarks.sh
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just kept this for the sake of consistency across the two files. I am running the PR benchmark on the
$BRANCH_NAME/pr/NullAway
folder (the whole$BRANCH_NAME
directory was set up to avoid errors due to any residual files from other PRs), and I am navigating back to the root directory after that's done. I can omit thecd $BRANCH_NAME
frommain
, but that would mean that I will have to go up two directories to the$BRANCH_NAME
folder in the step where I run the gcloud ssh command. Happy to make those changes if they are more suitable @msridhar. Thank you!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's fine to keep, was just curious.