Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP instead of SSH for cloning repo for JMH Benchmarks #1056

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

armughan11
Copy link
Collaborator

@armughan11 armughan11 commented Oct 10, 2024

Changed git clone to use HTTP since we only need read-only access and don't need to unnecessarily depend on SSH keys and authentication

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (cc5ef65) to head (616b06e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1056   +/-   ##
=========================================
  Coverage     87.61%   87.61%           
  Complexity     2183     2183           
=========================================
  Files            85       85           
  Lines          7161     7161           
  Branches       1404     1404           
=========================================
  Hits           6274     6274           
  Misses          453      453           
  Partials        434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar
Copy link
Collaborator

msridhar commented Oct 10, 2024

Here is a run, please check that it worked?

https://github.com/uber/NullAway/actions/runs/11282706070/job/31380727403

Looks ok to me thus far.

Edit: it worked!

@msridhar msridhar merged commit 0f6f3d2 into uber:master Oct 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants