JSpecify: handle intersection type in one place #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
============================================
+ Coverage 85.98% 86.00% +0.01%
- Complexity 2080 2086 +6
============================================
Files 83 83
Lines 6892 6901 +9
Branches 1328 1329 +1
============================================
+ Hits 5926 5935 +9
Misses 551 551
Partials 415 415 ☔ View full report in Codecov by Sentry. |
msridhar
added
the
jspecify
lazaroclapp
approved these changes
Aug 18, 2024
| " var x = (A<String> & Serializable) o;", | ||
| " // BUG: Diagnostic contains: Cannot assign from type B to type A<String> & Serializable", | ||
| " x = new B();", | ||
| " }", |
There was a problem hiding this comment.
To be clear, the case where we have:
" var x = (A<@Nullable String> & Serializable) o;",
" x = new B();",
Should have no error, right? Should we encode that test case just to make sure we never regress that?
There was a problem hiding this comment.
you're right, and i think we will get a false positive on that test for now (since for some reason var-declared variables don't get types with all the right annotations). i'll add tests and open an issue for outstanding tasks, but will fix in a subsequent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intersection types may arise, e.g., as part of string concatenation. We handling of an intersection type for one scenario; broader handling definitely requires more testing and thinking.
Fixes #1013