Implement coroutines interop module #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are coming, just sticking up for early review for the implementation. Still not 100% sure I know what I'm doing with structured concurrency so want to get more eyes on this :) |
...terop/src/main/kotlin/com/uber/autodispose/coroutinesinterop/AutoDisposeCoroutinesInterop.kt
Show resolved
Hide resolved
These come transitively
ZacSweers
force-pushed
the
z/coroutinScopeInterop
branch
from
ede28a3
to
d186f8f
Compare
|
Implemented the tests in d186f8f I'm still not totally sure about requiring a |
|
Went for it after digging through some coroutines sources. I think that's the right move. |
Super nice high order function with receiver API
|
Wrote something really nice building on top of the building blocks here. Now you can do this: scopeProvider.asCoroutineScope {
someObservable.autoDispose().subscribe()
} |
|
Pulled out the context APIs to #375 instead |
ShaishavGandhi
approved these changes
Sep 15, 2019
| import kotlinx.coroutines.isActive | ||
| import org.junit.Test | ||
|
|
||
| class AutoDisposeCoroutinesInteropTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new interop artifact for interop between
Completable/ScopeProviderandCoroutineScope. The idea is to offer this interop for general use, but also so anyone migrating from rx to coroutines (or the other way around!) can reuse existing machinery to ease migrations in the meantime.Resolves #371