-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate feedback from #130 #138
Merged
Merged
Commits on Nov 18, 2017
-
Configuration menu - View commit details
-
Copy full SHA for bd22bc2 - Browse repository at this point
Copy the full SHA bd22bc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for caf904a - Browse repository at this point
Copy the full SHA caf904aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79e6dbf - Browse repository at this point
Copy the full SHA 79e6dbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94212eb - Browse repository at this point
Copy the full SHA 94212ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bf1993 - Browse repository at this point
Copy the full SHA 9bf1993View commit details -
Opportunistic tweak of RxErrorsRule
Adds a convenience assertion and uses peek instead of poll for hasError
Configuration menu - View commit details
-
Copy full SHA for 53eef69 - Browse repository at this point
Copy the full SHA 53eef69View commit details -
Lazyset disposables in scope callbacks to prevent double subscriptions
These were missing before and necessary to mark this observer as appropriately disposed after, though without calling dispose()
Configuration menu - View commit details
-
Copy full SHA for 7ac1488 - Browse repository at this point
Copy the full SHA 7ac1488View commit details -
Configuration menu - View commit details
-
Copy full SHA for d564b40 - Browse repository at this point
Copy the full SHA d564b40View commit details -
Wire up HalfSerializer to observer and subscribers
I'm not 100% I've done this right, but leveraging some existing examples in RxJava as my guide. I've copied in the relevant internal rxjava APIs (since they're internal) and also adjusted the onNext methods to return true or false indicating whether or not they terminated the underlying observer. Will seek further feedback during the PR. Main thing I'm not sure of is if it does terminate, do we need to dispose the lifecycle or does this mean that onError or onComplete have been hit in the main observer already (and doing so is a double dispose condition)
Configuration menu - View commit details
-
Copy full SHA for cb432a8 - Browse repository at this point
Copy the full SHA cb432a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07f0f1e - Browse repository at this point
Copy the full SHA 07f0f1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec190c0 - Browse repository at this point
Copy the full SHA ec190c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9606ae4 - Browse repository at this point
Copy the full SHA 9606ae4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b38d03f - Browse repository at this point
Copy the full SHA b38d03fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7705288 - Browse repository at this point
Copy the full SHA 7705288View commit details -
Configuration menu - View commit details
-
Copy full SHA for daad41b - Browse repository at this point
Copy the full SHA daad41bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 500f337 - Browse repository at this point
Copy the full SHA 500f337View commit details
Commits on Nov 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for e7e1b87 - Browse repository at this point
Copy the full SHA e7e1b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0d8556 - Browse repository at this point
Copy the full SHA a0d8556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22ba683 - Browse repository at this point
Copy the full SHA 22ba683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 959fe09 - Browse repository at this point
Copy the full SHA 959fe09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a45aa4 - Browse repository at this point
Copy the full SHA 6a45aa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44b362f - Browse repository at this point
Copy the full SHA 44b362fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba8bd87 - Browse repository at this point
Copy the full SHA ba8bd87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3edf4 - Browse repository at this point
Copy the full SHA 9c3edf4View commit details -
Optimize lifecycle error propagation a bit
We were disposing the lifecycle a second time after, and unnecessarily disposing the main disposable twice too
Configuration menu - View commit details
-
Copy full SHA for 3b87876 - Browse repository at this point
Copy the full SHA 3b87876View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.