Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate feedback from #130 #138

Merged
merged 25 commits into from
Dec 3, 2017
Merged

Incorporate feedback from #130 #138

merged 25 commits into from
Dec 3, 2017

Commits on Nov 18, 2017

  1. Configuration menu
    Copy the full SHA
    bd22bc2 View commit details
    Browse the repository at this point in the history
  2. Fix introspection typo

    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    caf904a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79e6dbf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94212eb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9bf1993 View commit details
    Browse the repository at this point in the history
  6. Opportunistic tweak of RxErrorsRule

    Adds a convenience assertion and uses peek instead of poll for hasError
    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    53eef69 View commit details
    Browse the repository at this point in the history
  7. Lazyset disposables in scope callbacks to prevent double subscriptions

    These were missing before and necessary to mark this observer as appropriately disposed after, though without calling dispose()
    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    7ac1488 View commit details
    Browse the repository at this point in the history
  8. Inline lazyDispose() methods

    Saving dex methods
    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    d564b40 View commit details
    Browse the repository at this point in the history
  9. Wire up HalfSerializer to observer and subscribers

    I'm not 100% I've done this right, but leveraging some existing examples in RxJava as my guide. I've copied in the relevant internal rxjava APIs (since they're internal) and also adjusted the onNext methods to return true or false indicating whether or not they terminated the underlying observer. Will seek further feedback during the PR. Main thing I'm not sure of is if it does terminate, do we need to dispose the lifecycle or does this mean that onError or onComplete have been hit in the main observer already (and doing so is a double dispose condition)
    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    cb432a8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    07f0f1e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ec190c0 View commit details
    Browse the repository at this point in the history
  12. Inline lazyDispose() impl

    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    9606ae4 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b38d03f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7705288 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    daad41b View commit details
    Browse the repository at this point in the history
  16. Use deferred requesting

    ZacSweers committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    500f337 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Configuration menu
    Copy the full SHA
    e7e1b87 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0d8556 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22ba683 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    959fe09 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6a45aa4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    44b362f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ba8bd87 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9c3edf4 View commit details
    Browse the repository at this point in the history
  9. Optimize lifecycle error propagation a bit

    We were disposing the lifecycle a second time after, and unnecessarily disposing the main disposable twice too
    ZacSweers committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    3b87876 View commit details
    Browse the repository at this point in the history