Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint suppressions and use custom observers in lifecycle subscriptions #108

Merged
merged 4 commits into from
Oct 16, 2017
Merged

Lint suppressions and use custom observers in lifecycle subscriptions #108

merged 4 commits into from
Oct 16, 2017

Commits on Oct 15, 2017

  1. Suppress warnings in weaker access calls

    @ZacSweers
    ZacSweers committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    f25d71a View commit details
    Browse the repository at this point in the history

  2. Create full disposable observers with documented noop and less alloc 

    This changes the lifecycle subscriptions to use full observers to save some allocations, and also documents the noop on completions
    @ZacSweers
    ZacSweers committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    1ce6263 View commit details
    Browse the repository at this point in the history

  3. Add unbound() factory

    @ZacSweers
    ZacSweers committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    625bc2b View commit details
    Browse the repository at this point in the history

  4. Inline subscribe check calls to observer 

    Saves some more allocs
    @ZacSweers
    ZacSweers committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    52718a4 View commit details
    Browse the repository at this point in the history