Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed synthentic accessor from auto disposables and recording observer #103

Merged
merged 1 commit into from
Oct 8, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private void lazyDispose() {
}
}

private void callMainSubscribeIfNecessary(Disposable d) {
/* private */
void callMainSubscribeIfNecessary(Disposable d) {
// If we've never actually called the downstream onSubscribe (i.e. requested immediately in
// onSubscribe and had a terminal event), we need to still send an empty disposable instance
// to abide by the Observer contract.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private void lazyDispose() {
}
}

private void callMainSubscribeIfNecessary(Disposable d) {
/* private */
void callMainSubscribeIfNecessary(Disposable d) {
// If we've never actually called the downstream onSubscribe (i.e. requested immediately in
// onSubscribe and had a terminal event), we need to still send an empty disposable instance
// to abide by the Observer contract.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private void lazyDispose() {
}
}

private void callMainSubscribeIfNecessary(Disposable d) {
/* private */
void callMainSubscribeIfNecessary(Disposable d) {
// If we've never actually called the downstream onSubscribe (i.e. requested immediately in
// onSubscribe and had a terminal event), we need to still send an empty disposable instance
// to abide by the Observer contract.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private void lazyDispose() {
}
}

private void callMainSubscribeIfNecessary(Disposable d) {
/* private */
void callMainSubscribeIfNecessary(Disposable d) {
// If we've never actually called the downstream onSubscribe (i.e. requested immediately in
// onSubscribe and had a terminal event), we need to still send an empty disposable instance
// to abide by the Observer contract.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ private void lazyCancel() {
}
}

private void callMainSubscribeIfNecessary(Subscription s) {
/* private */
void callMainSubscribeIfNecessary(Subscription s) {
// If we've never actually started the upstream subscription (i.e. requested immediately in
// onSubscribe and had a terminal event), we need to still send an empty subscription instance
// to abide by the Subscriber contract.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ public void assertNoMoreEvents() {
private final class OnNext {
final T value;

private OnNext(T value) {
/* private */
OnNext(T value) {
this.value = value;
}

Expand All @@ -141,9 +142,11 @@ private static final class OnCompleted {
}

private static final class OnError {
private final Throwable throwable;
/* private */
final Throwable throwable;

private OnError(Throwable throwable) {
/* private */
OnError(Throwable throwable) {
this.throwable = throwable;
}

Expand All @@ -153,9 +156,11 @@ private OnError(Throwable throwable) {
}

private static final class OnSubscribe {
private final Disposable disposable;
/* private */
final Disposable disposable;

private OnSubscribe(Disposable disposable) {
/* private */
OnSubscribe(Disposable disposable) {
this.disposable = disposable;
}

Expand All @@ -165,9 +170,11 @@ private OnSubscribe(Disposable disposable) {
}

private final class OnSuccess {
private final T value;
/* private */
final T value;

private OnSuccess(T value) {
/* private */
OnSuccess(T value) {
this.value = value;
}

Expand Down