-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Initial support for MDX #179
Conversation
options: { | ||
extensions: ['.mdx'] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just want to point out that this is precisely where ocular-gatsby is useful. existing sites just have to upgrade ocular-gatsby, not change their manual configurations or add new dependencies :)
).then(result => { | ||
if (result.errors) { | ||
/* eslint no-console: "off" */ | ||
console.log(result.errors); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no logger?
|
||
return queryMdxDocs(graphql) | ||
.then(result => { | ||
// const rootFolder = result.data.site.siteMetadata.config.ROOT_FOLDER; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why comment it out? is that temporary?
} | ||
`; | ||
|
||
// function replaceLinks(props) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I'm considering extending this functionality to more elements for the "regular" doc file (ie replacing h1, h2, pre, table etc. DOM elements generated by markdown and whose styling depends on scss by styled components).
Ib Green seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Remaining work:
MDXRenderer
per link below.Links