Added zapcore.TimeEncoderOfLayout #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 98.33% 98.35% +0.01%
==========================================
Files 43 43
Lines 2349 2366 +17
==========================================
+ Hits 2310 2327 +17
Misses 32 32
Partials 7 7
Continue to review full report at Codecov.
|
|
Actually I'm wondering which word to use, "format" or "layout"... |
abhinav
reviewed
Jun 18, 2020
Good question, since Go tends to use the word layout for the argument, it makes sense to use that in the YAML config. |
|
Don't know why codecov fails... |
abhinav
approved these changes
Jun 23, 2020
abbrev should be UPPERCASE Co-authored-by: Abhinav Gupta <[email protected]>
prashantv
changed the title
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
I added `zapcore.TimeEncoderOfFormat` to make it easy to build `TimeEncoder` of custom format.
You can use it in code:
```go
config := zap.NewDevelopmentConfig()
config.EncoderConfig.EncodeTime = zapcore.TimeEncoderOfLayout("06/01/02 03:04pm")
```
or, with JSON:
```json
{
"encoderConfig": {
"timeEncoder": {
"layout": "06/01/02 03:04pm"
}
}
}
```
or, with YAML:
```yaml
encoderConfig:
timeEncoder:
layout: '06/01/02 03:04pm'
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
zapcore.TimeEncoderOfFormatto make it easy to buildTimeEncoderof custom format.You can use it in code:
or, with JSON:
{ "encoderConfig": { "timeEncoder": { "layout": "06/01/02 03:04pm" } } }or, with YAML: