Lint on Go 1.9, drop 1.7 #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already building on Go 1.9; now that it's been out for a bit, start running the linters there too. Since we're only committed to supporting the last two releases, drop 1.7 to speed up Travis runs. Fixes #509.
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 37 37
Lines 2272 2272
=======================================
Hits 2209 2209
Misses 56 56
Partials 7 7Continue to review full report at Codecov.
|
abhinav
approved these changes
Oct 31, 2017
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
We're already building on Go 1.9; now that it's been out for a bit, start running the linters there too. Since we're only committed to supporting the last two releases, drop 1.7 to speed up Travis runs. Fixes uber-go#509.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already building on Go 1.9; now that it's been out for a bit,
start running the linters there too. Since we're only committed to
supporting the last two releases, drop 1.7 to speed up Travis runs.
Fixes #509.