Ignore Sync errors #347
Merged
Ignore Sync errors #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ulexus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah to be a potential reviewer. |
|
|
|
I'm not sure just ignoring a sync error is the best way to go about this - any other ideas? |
|
I'm going to push some commits to take this PR in a different (simpler) direction. However, we really appreciate the time you've taken on this - I'll make sure to preserve your authorship of the changes. |
|
Yeah, sorry I haven't had time to work on this more. If you've a better idea, please take it where you want! |
|
No worries at all - appreciate the work that you've already put in! |
If call to `Sync()` fails, wrap the WriteSyncer with a fake `Sync()`. Fixes uber-go#328
This reverts commit 9da32f3.
prashantv
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the simplest approach to fixing the cross-platform compatibility issues with syncing stderr and stdout (outlined in #328) and just ignore sync errors. If we come up with a clean solution to #370, we can revert this change.
Fixes #328.