Update changelog and readme for RC 2 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshayjshah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @chapsuk, @peter-edge and @eklitzke to be potential reviewers. |
|
Planning changes to make the PR numbers into links. Will fix today and land when I have a moment. |
akshayjshah
force-pushed
the
ajs-rc-2
branch
4 times, most recently
from
160140d to
a6ddd81
Compare
akshayjshah
force-pushed
the
ajs-rc-2
branch
from
a6ddd81 to
2f9de18
Compare
ascandella
approved these changes
Feb 23, 2017
abhinav
approved these changes
Feb 23, 2017
| * [#326][]: Though `New(nil)` continues to return a no-op logger, `NewNop()` is | ||
| now preferred. Users can update their projects with `gofmt -r 'zap.New(nil) -> | ||
| zap.NewNop()' -w .`. | ||
| * [#300][]: Incorrectly importing zap as `github.com/uber-go/zap` now returns a |
There was a problem hiding this comment.
Inconsistent capitalization. You're using "Zap" to refer to the project everywhere else.
Incorrectly importing Zap [..]
There was a problem hiding this comment.
(edited)
Actually, I don't think this is inconsistent - it's just that the first word in a sentence is capitalized, and "zap" is often the first word in sentences.
prashantv
approved these changes
Feb 23, 2017
bufdev
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CHANGELOG and README in preparation for a second release candidate.