Add benchmarks for chained Withs #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquirke
force-pushed
the
benchmark-chained-loggers
branch
from
2fcb933
to
5423557
Compare
jquirke
changed the title
jquirke
force-pushed
the
benchmark-chained-loggers
branch
from
5423557
to
991ed31
Compare
abhinav
reviewed
Aug 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #1326 +/- ##
==========================================
- Coverage 97.77% 97.62% -0.15%
==========================================
Files 51 51
Lines 3366 3366
==========================================
- Hits 3291 3286 -5
- Misses 65 69 +4
- Partials 10 11 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jquirke
force-pushed
the
benchmark-chained-loggers
branch
4 times, most recently
from
3864e3c
to
6be7c84
Compare
Add benchmarks to show the performance of chaining child loggers via 'With' and whether the logger is used or not used. This is intended to establish a baseline for a proposed optimisation in PR uber-go#1319, in particular, we would like to see if we can avoid the expense of With() if a logger is never used. Currently, the performance is similar irrespective of whether the logger is used or not: ``` % go test -bench=Benchmark5Withs goos: darwin goarch: arm64 pkg: go.uber.org/zap Benchmark5WithsUsed-10 512342 2276 ns/op Benchmark5WithsNotUsed-10 570768 2201 ns/op ```
jquirke
force-pushed
the
benchmark-chained-loggers
branch
from
6be7c84
to
8f81672
Compare
abhinav
approved these changes
Aug 18, 2023
|
I'm late, but thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks to show the performance of chaining child loggers via 'With' and whether the logger is used or not used.
This is intended to establish a baseline for a proposed optimisation in PR #1319.