Replace 'Interface' usage with correct zerolog api #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle structures as documented in zerolog, similar to how zap does in it's test case.
|
|
|
Hello, @Emyrk! Thanks for the change. Would you please sign the CLA? |
|
@abhinav I believe I have signed it |
abhinav
approved these changes
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
- Coverage 98.29% 98.19% -0.10%
==========================================
Files 48 48
Lines 2111 2111
==========================================
- Hits 2075 2073 -2
- Misses 28 29 +1
- Partials 8 9 +1
Continue to review full report at Codecov.
|
sywhang
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle structures as documented in zerolog, similar to how zap does in it's test case.
I'm not sure which test is which on the README.md, so that will need to be updated.