Incorrect time value with zap.Time() when using a time far in the future #803
Comments
|
This is similar to #737 I think we should do the same fix as suggested there: if a value is out-of-range for |
prashantv
added a commit
that referenced
this issue
Mar 24, 2020
Fixes #737, #803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
prashantv
added a commit
that referenced
this issue
Mar 27, 2020
Fixes #737, #803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
|
Resolved in #804 |
uvfive
pushed a commit
to bxsmart/zap
that referenced
this issue
May 21, 2020
Fixes uber-go#737, uber-go#803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this issue
Mar 25, 2022
Fixes uber-go#737, uber-go#803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to log a time value that is set to something very far in the future. It is supposedly the largest time value possible according to https://stackoverflow.com/a/25065327/793930.
I'm using the plain
Logger, and creating the field for the log message usingzap.Time().https://play.golang.org/p/Nc8jv_8NkCs
If you run the code in the playground, you'll see that
t1is the same in both the zap log and in thefmt.Printlnprint. However,t2is reported incorrectly in the zap log as:The text was updated successfully, but these errors were encountered: