update go-statsd-client to v5 #194
Merged
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
|
@brawndou @SokolAndrey please review when time permits. We'd like to see this dependency upgrade get merged in to keep our code base using the latest dependencies |
|
Apologies, @nitrocode, I don't work at Uber anymore and don't have maintainer privileges in this repository. |
brawndou
added a commit
that referenced
this pull request
Mar 30, 2023
Release of 4.1.7 Changes: - update go-statsd-client to v5 (#194)
Merged
brawndou
added a commit
that referenced
this pull request
Mar 30, 2023
Release of 4.1.7 Changes: - update go-statsd-client to v5 (#194)
|
Thank you! I see the latest version is 4.1.7. we'll upgrade to 4.x. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current go-statsd-client is too old. Dependency commit is 2years ago.
https://github.com/cactus/go-statsd-client/tree/cb0885a1018c53bc05535cfbbd1fb858430b9f8c
Discussion
It has a breaking change on
func NewReporter(statsd statsd.Statter, opts Options) tally.StatsReporter.Upgrade guide is just change like a following.