-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for custom templates #129
Conversation
@abhinav just pinging you, in case you have a chance to look at this 😄 Also, thanks for merging the other PRs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and the other PRs, @hacdias, and thanks for waiting. I had to make some time to look over this. (The other PRs were a lot quicker to review. 😅)
I'm in favor of this change in general, and I appreciate the rigor that went into this. This is a good PR. I have only a couple minor suggestions. It should be good to merge after that.
Thanks!
@abhinav thanks! I addressed your feedback, and also cleaned up a few things I saw along the way. Looking forward to see this merged. I found many packages like this one, but none did exactly what I wanted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers. This is great! Thanks @hacdias!
I'm okay with this as-is, but if you'd like to make getTestTemplates
take a testing.TB
, I can wait a day.
@abhinav thanks for the review! I applied the feedback, and I think it's ready to be merged. |
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 80.14% 76.11% -4.04%
==========================================
Files 3 3
Lines 136 180 +44
==========================================
+ Hits 109 137 +28
- Misses 23 39 +16
Partials 4 4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Merged! Thanks, @hacdias |
Closes #125 (see for more context). This PR:
-templates
flag that can be used to provide a directory with templates. They override existing ones for users that want to customize how the pages look.serveHTML