Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: documentation URL in index page #126

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: documentation URL in index page #126

merged 1 commit into from
Nov 7, 2023

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented Nov 7, 2023

Fixes the documentation URL in the homepage, as it already includes the protocol:

sally/handler.go

Line 45 in 686fb87

docURL := "https://" + path.Join(config.Godoc.Host, modulePath)

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hacdias hacdias changed the title fix: .DocURL already includes protocol fix: documentation URL in indx Nov 7, 2023
@hacdias hacdias changed the title fix: documentation URL in indx fix: documentation URL in index page Nov 7, 2023
abhinav
abhinav approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for fixing.

@abhinav abhinav merged commit 35e7777 into uber-go:master Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinav abhinav abhinav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @CLAassistant @abhinav