Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and lint against Go 1.19 #62

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Test and lint against Go 1.19 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: ["1.17.x", "1.18.x"]
go: ["1.17.x", "1.18.x", "1.19.x"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 1.17.x be dropped?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't been dropping 1.17 from any other package just yet because 1.19 is super new and there's a good chance that many users haven't migrated to 1.18 just yet.

But yes, we should drop this in a future change.

include:
- go: 1.18.x
- go: 1.19.x
latest: true

steps:
Expand Down
3 changes: 1 addition & 2 deletions appendinvoke_example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ package multierr_test

import (
"fmt"
"io/ioutil"
"log"
"os"
"path/filepath"
Expand All @@ -37,7 +36,7 @@ func ExampleAppendInvoke() {
}

func run() (err error) {
dir, err := ioutil.TempDir("", "multierr")
dir, err := os.MkdirTemp("", "multierr")
// We create a temporary directory and defer its deletion when this
// function returns.
//
Expand Down
Loading