Parse stack traces to avoid string contains checks #41
Comments
abhinav
added a commit
that referenced
this issue
Oct 21, 2023
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
abhinav
added a commit
that referenced
this issue
Oct 21, 2023
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
abhinav
added a commit
that referenced
this issue
Oct 21, 2023
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
abhinav
added a commit
that referenced
this issue
Oct 22, 2023
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
abhinav
added a commit
that referenced
this issue
Oct 23, 2023
Adds support to the stack parser for reading the full list of functions for a stack trace. NOTE: The function that created the goroutine is NOT considered part of the stack. We don't maintain the order of the functions since that's not something we need at this time. The functions are all placed in a set. This unblocks #41 and allows implementing an IgnoreAnyFunction option (similar to the stalled #80 PR). Depends on #110
abhinav
added a commit
that referenced
this issue
Oct 23, 2023
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
abhinav
added a commit
that referenced
this issue
Oct 23, 2023
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
Depends on #111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a couple of
strings.Containschecks , e.g.,goleak/options.go
Line 142 in 7380c5a
We should parse the stack trace and filter on specific parts of the trace (E.g., only function name) rather than doing a string comparison against the entire stack trace which contains filesystem paths etc.
The text was updated successfully, but these errors were encountered: