More details to a todo

uber-go · Feb 21, 2017 · 00f640e · 00f640e
1 parent 8bc5fb6
commit 00f640e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/modules/rpc/thrift_test.go b/modules/rpc/thrift_test.go
@@ -94,8 +94,6 @@ modules:
     inbounds:
      - tchannel:
          port: 0
-     - http:
-         port: 0
 `)
 
 	mci := service.ModuleCreateInfo{
@@ -116,7 +114,7 @@ modules:
 	// Dispatcher must be resolved in the new graph
 	var dispatcher *yarpc.Dispatcher
 	assert.NoError(t, di.Resolve(&dispatcher))
-	assert.Equal(t, 2, len(dispatcher.Inbounds()))
+	assert.Equal(t, 1, len(dispatcher.Inbounds()))
 }
 
 func TestThriftModule_BadOptions(t *testing.T) {

diff --git a/modules/rpc/yarpc.go b/modules/rpc/yarpc.go
@@ -271,7 +271,8 @@ func newYARPCModule(
 	di := graphFromCreateInfo(mi)
 
 	// Try to resolve a controller first
-	// TODO(alsam) use dig options when available.
+	// TODO(alsam) use dig options when available, because we can overwrite the controller in case of multiple
+	// modules registering a controller.
 	if err := di.Resolve(&module.controller); err != nil {
 
 		// Try to register it then