v1.5.0 I am still getting that the CPU Quota is not defined.

[dprotaso]

Originally posted by @ardan-bkennedy in #44 (comment)

This change has not fixed the problem. I switched my code from "github.com/emadolsky/automaxprocs/maxprocs" to v1.5.0 and I am still getting that the CPU Quota is not defined.

I noticed that in v1.5.0

https://github.com/uber-go/automaxprocs/blob/v1.5.0/internal/runtime/cpu_quota_linux.go#L35

func CPUQuotaToGOMAXPROCS(minValue int) (int, CPUQuotaStatus, error) {[Jason Lai, 5 years ago: • Import `automaxprocs/x/runtime`](https://sourcegraph.com/github.com/uber-go/automaxprocs/-/commit/572239b375b1ca6b76babeb8b0ee139dc35fd4d8)
	cgroups, err := newQueryer()
	if err != nil {
		return -1, CPUQuotaUndefined, err
	}

	quota, defined, err := cgroups.CPUQuota()
	if !defined || err != nil {
		return -1, CPUQuotaUndefined, err
	}

	maxProcs := int(math.Floor(quota))
	if minValue > 0 && maxProcs < minValue {
		return minValue, CPUQuotaMinUsed, nil
	}
	return maxProcs, CPUQuotaUsed, nil
}

var (
	_newCgroups2 = cg.NewCGroups2ForCurrentProcess
	_newCgroups  = cg.NewCGroupsForCurrentProcess
)

func newQueryer() (queryer, error) {
	cgroups, err := _newCgroups2()
	if err == nil {
		return cgroups, nil
	}
	if errors.Is(err, cg.ErrNotV2) {
		return _newCgroups()
	}
	return nil, err
}

In the emadolsky repo, it's working. I don't know enough to tell you why.

func CPUQuotaToGOMAXPROCS(minValue int) (int, CPUQuotaStatus, error) {
	var quota float64
	var defined bool
	var err error

	isV2, err := cg.IsCGroupV2()
	if err != nil {
		return -1, CPUQuotaUndefined, err
	}

	if isV2 {
		quota, defined, err = cg.CPUQuotaV2()
		if !defined || err != nil {
			return -1, CPUQuotaUndefined, err
		}
	} else {
		cgroups, err := cg.NewCGroupsForCurrentProcess()
		if err != nil {
			return -1, CPUQuotaUndefined, err
		}

		quota, defined, err = cgroups.CPUQuota()
		if !defined || err != nil {
			return -1, CPUQuotaUndefined, err
		}
	}

	maxProcs := int(math.Floor(quota))
	if minValue > 0 && maxProcs < minValue {
		return minValue, CPUQuotaMinUsed, nil
	}
	return maxProcs, CPUQuotaUsed, nil
}

[dprotaso]

cc @abhinav @mway

[ardan-bkennedy]

The code is public domain if someone wants to look at what I'm running. I am using the latest version v0.12 of KIND and the recommended container.

https://github.com/ardanlabs/service

https://github.com/ardanlabs/service/blob/master/app/services/sales-api/main.go

[emadolsky]

@ardan-bkennedy - Yes the merged version seems to have issues. Probably, I will be able to take a look at it 'til the end of the day.

[ardan-bkennedy]

Brilliant and thanks for all the attention on this. Very much appreciated.

[abhinav]

Thanks for the report @emadolsky @ardan-bkennedy!
Our apologies. Looks like we broke it somewhere in the refactoring/testing.

The point where it decides between cgroups2 and 1 is here:

automaxprocs/internal/runtime/cpu_quota_linux.go

Lines 63 to 70 in 2e85815

	cgroups, err := _newCgroups2()
	if err == nil {
	return cgroups, nil
	}
	if errors.Is(err, cg.ErrNotV2) {
	return _newCgroups()
	}
	return nil, err

But I think the issue is here:

automaxprocs/internal/cgroups/cgroups2.go

Lines 91 to 94 in 2e85815

	newMountPoint = func(mp *MountPoint) error {
	isV2 = mp.FSType == _cgroupv2FSType && mp.MountPoint == _cgroupv2MountPoint
	return nil
	}

We made a small mistake there with the refactoring: we turned "if any of the mount points meet this condition" to "if the last mount point meets this condition". The tests didn't catch it because the test mountinfo file has a single entry.

We'll get this fixed and push a patch release ASAP.

[abhinav]

Fix released. Thanks for flagging this @emadolsky @ardan-bkennedy!

[ardan-bkennedy]

Brilliant. Can't wait to test it later today!!

[ardan-bkennedy]

YES!!! This is working!!! THANK YOU!

[shcw]

I'm still having this problem with 1.5.3 😭😭😭😭😭😭