Skip to content

Commit

Permalink
Add checking value is null in declareDependenciesAndCheckValues.
Browse files Browse the repository at this point in the history
Return earlier if any value is missing, don't need to iterate over.

PiperOrigin-RevId: 436189630
  • Loading branch information
emilyguo1 authored and copybara-github committed Mar 21, 2022
1 parent 5f1087c commit 7812bdc
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ private static void declareDependenciesAndCheckValues(
Environment env, Iterable<? extends SkyKey> skyKeys) throws InterruptedException {
SkyframeIterableResult result = env.getOrderedValuesAndExceptions(skyKeys);
while (result.hasNext()) {
result.next();
if (result.next() == null) {
return;
}
}
}

Expand Down

0 comments on commit 7812bdc

Please sign in to comment.