Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

directly use the return value of statsrelay_list_expand #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

directly use the return value of statsrelay_list_expand #46

wants to merge 1 commit into from

Conversation

eklitzke
Copy link
Contributor

With 7f5333c I fixed the bug whereby statsrelay_list_expand was returning the wrong address (note: the old code was valid because statsrelay_list_expand still returned NULL in the right cases, but the non-NULL case had the wrong offset). This change uses the return value of statsrelay_list_expand directly, rather than computing the offset, which is slightly more efficient.

@JeremyGrosser
Copy link
Contributor

LGTM

yashsarma referenced this pull request in lyft/statsrelay Feb 8, 2017
@zimrideops @lyft-buildnotify
weekly opsbase update (#46)
4bdf911 
Author: none

**Files changed (55):**
base/ops/config/pillar/deleted_iam_objects.sls (+2 -0 ~2)
base/ops/config/pillar/github_teams.sls (+2 -0 ~2)
base/ops/config/pillar/lyft_users.sls (+11 -9 ~20)
base/ops/config/pillar/roles.sls (+1 -0 ~1)
base/ops/config/pillar/services.sls (+9 -0 ~9)
base/ops/config/states/base/statsd/statsrelay-base.json (+1 -1 ~2)
base/ops/config/states/envoy2/init.sls (+3 -3 ~6)
bootartifact/Dockerfile (+1 -1 ~2)
buildnotify/Dockerfile (+1 -1 ~2)
buildnotify/buildnotify/__init__.py (+0 -4 ~4)
buildnotify/buildnotify/jenkins.py (+3 -3 ~6)
buildnotify/buildnotify/routes.py (+2 -4 ~6)
buildnotify/buildnotify/services.py (+8 -3 ~11)
buildnotify/buildnotify/settings.py (+6 -1 ~7)
buildnotify/buildnotify/tests/test_services.py (+5 -40 ~45)
buildnotify/buildnotify/tests/test_v3_callbacks.py (+54 -0 ~54)
buildnotify/buildnotify/tests/test_v3_jenkins.py (+12 -0 ~12)
buildnotify/buildnotify/tests/test_v3_jenkins_jobs.py (+134 -0 ~134)
buildnotify/buildnotify/tests/test_v3_models.py (+22 -0 ~22)
buildnotify/buildnotify/tests/test_v3_services.py (+29 -3 ~32)
buildnotify/buildnotify/tests/test_workflow_repositories.py (+0 -21 ~21)
buildnotify/buildnotify/v2_services.py (+24 -44 ~68)
buildnotify/buildnotify/v3_callbacks.py (+26 -4 ~30)
buildnotify/buildnotify/v3_jenkins.py (+28 -0 ~28)
buildnotify/buildnotify/v3_jenkins_jobs.py (+55 -1 ~56)
buildnotify/buildnotify/v3_models.py (+36 -0 ~36)
buildnotify/buildnotify/v3_services.py (+10 -5 ~15)
buildnotify/buildnotify/workflow_repositories.py (+0 -18 ~18)
buildnotify/ops/config/pillar/env.sls (+3 -0 ~3)
docs/mongodb/runbook.md (+21 -0 ~21)
gateway/Dockerfile (+1 -1 ~2)
grafana/Dockerfile (+1 -1 ~2)
grafana/OWNERS (+5 -0 ~5)
graphite/OWNERS (+5 -0 ~5)
jenkins/apitestrevisions/force_update_last_good_revision.py (+8 -17 ~25)
jenkins/apitestrevisions/get_last_good_revision.py (+1 -0 ~1)
jenkins/apitestrevisions/store_last_good_revision.py (+1 -1 ~2)
jenkins/docs/runbook.md (+1 -1 ~2)
jenkins/ops/config/states/OWNERS (+1 -0 ~1)
jenkins/ops/config/states/jenkins/config/config.xml (+13 -11 ~24)
jenkins/ops/config/states/jenkins/templates/build_image.xml (+12 -0 ~12)
jenkins/ops/orca/jenkins.sls (+9 -0 ~9)
opstools/Dockerfile (+1 -1 ~2)
opstools/OWNERS (+5 -0 ~5)
opstools/ops/orca/opstools.sls (+6 -0 ~6)
opstools/redis_tools/README.md (+48 -0 ~48)
opstools/redis_tools/redis_hot_key_tool.py (+122 -0 ~122)
orca/Dockerfile (+1 -1 ~2)
orca/pillar/aws.sls (+11 -4 ~15)
redis/ops/config/states/redis/redis_traffic_logger.py (+53 -0 ~53)
statsd/Dockerfile (+1 -1 ~2)
statsd/OWNERS (+5 -0 ~5)
vpcproxy/Dockerfile (+1 -1 ~2)
vpn/Dockerfile (+1 -1 ~2)
vpn/ops/config/states/vpn/users.yaml (+1 -1 ~2)

**33 commits:**
[weekly opsbase update (#9607)](lyft/ops_DEPRECATED@8a4fbf7)
[weekly opsbase update (#9608)](lyft/ops_DEPRECATED@3f52258)
[weekly opsbase update (#9609)](lyft/ops_DEPRECATED@e7ac9a9)
[weekly opsbase update (#9610)](lyft/ops_DEPRECATED@28c917c)
[weekly opsbase update (#9611)](lyft/ops_DEPRECATED@5d1849c)
[weekly opsbase update (#9612)](lyft/ops_DEPRECATED@4a257e6)
[weekly opsbase update (#9613)](lyft/ops_DEPRECATED@f99e037)
[weekly opsbase update (#9614)](lyft/ops_DEPRECATED@9a1d57b)
[weekly opsbase update (#9615)](lyft/ops_DEPRECATED@fc556dc)
[Send all of envoy.mongo to faststatsd (#9604)](lyft/ops_DEPRECATED@d8a243d)
[added some iam users to delete (#9617)](lyft/ops_DEPRECATED@d0daff7)
[add amartin to EngineeringVPNAccess (#9620)](lyft/ops_DEPRECATED@4831928)
[add JenkinsAccess github team (#9622)](lyft/ops_DEPRECATED@882058b)
[Providing Ikram Admin permissions (#9619)](lyft/ops_DEPRECATED@8a59730)
[restrict Jenkins access to everyone in the Dev github group (#9621)](lyft/ops_DEPRECATED@5863206)
[fixed blind orca (#9624)](lyft/ops_DEPRECATED@753a939)
[Add mareksapota-lyft to Jenkins owners (#9623)](lyft/ops_DEPRECATED@4cd2d75)
[Add envoy to help service dependencies. (#9626)](lyft/ops_DEPRECATED@a948856)
[remove EngineeringVPNAccess now that JenkinsAccess is live (#9625)](lyft/ops_DEPRECATED@670ae5f)
[Envoy 68e349852b0b1fce27378cc3278ba7560e278fa4 (#9628)](lyft/ops_DEPRECATED@cba32dc)
[add knowledgeserver service (#9627)](lyft/ops_DEPRECATED@59281f9)
[Monitor redis traffic and determine hot keys across host (#9583)](lyft/ops_DEPRECATED@e84a2a0)
[envoy 25d583413dceda484617db6fc59e8086b483df0c (#9630)](lyft/ops_DEPRECATED@674480b)
[Add minimal documentation of metrics/observability for Mongo. (#9633)](lyft/ops_DEPRECATED@eb45c33)
[OWNERS (#9634)](lyft/ops_DEPRECATED@6ae86fd)
[Fix force update script (#9635)](lyft/ops_DEPRECATED@54c7277)
[Add enterprise tables to read-only-dynamo (#9637)](lyft/ops_DEPRECATED@1416c12)
[jenkins: allow master to store artifacts in ciexec s3 (#9641)](lyft/ops_DEPRECATED@d521e16)
[Adding Jenkins Mobile to V3 buildnotify (#9631)](lyft/ops_DEPRECATED@e613e74)
[Removing V2 workflow repositories (#9638)](lyft/ops_DEPRECATED@4591dd9)
[jenkins: make build_image report to ciexec (#9642)](lyft/ops_DEPRECATED@fed3467)
[Revert "Simplifying the upstream test process" (#9644)](lyft/ops_DEPRECATED@8d0c273)
[envoy prod 4c6ee5b673dc0ed2577b3ab83a2801fa23ee36a4 (#9647)](lyft/ops_DEPRECATED@0d41d85)
NOT PASSING TESTS
theatrus referenced this pull request in lyft/statsrelay May 1, 2020
@zimrideops @lyft-buildnotify
weekly opsbase update (#46)
11187ac 
Author: none

**Files changed (55):**
base/ops/config/pillar/deleted_iam_objects.sls (+2 -0 ~2)
base/ops/config/pillar/github_teams.sls (+2 -0 ~2)
base/ops/config/pillar/lyft_users.sls (+11 -9 ~20)
base/ops/config/pillar/roles.sls (+1 -0 ~1)
base/ops/config/pillar/services.sls (+9 -0 ~9)
base/ops/config/states/base/statsd/statsrelay-base.json (+1 -1 ~2)
base/ops/config/states/envoy2/init.sls (+3 -3 ~6)
bootartifact/Dockerfile (+1 -1 ~2)
buildnotify/Dockerfile (+1 -1 ~2)
buildnotify/buildnotify/__init__.py (+0 -4 ~4)
buildnotify/buildnotify/jenkins.py (+3 -3 ~6)
buildnotify/buildnotify/routes.py (+2 -4 ~6)
buildnotify/buildnotify/services.py (+8 -3 ~11)
buildnotify/buildnotify/settings.py (+6 -1 ~7)
buildnotify/buildnotify/tests/test_services.py (+5 -40 ~45)
buildnotify/buildnotify/tests/test_v3_callbacks.py (+54 -0 ~54)
buildnotify/buildnotify/tests/test_v3_jenkins.py (+12 -0 ~12)
buildnotify/buildnotify/tests/test_v3_jenkins_jobs.py (+134 -0 ~134)
buildnotify/buildnotify/tests/test_v3_models.py (+22 -0 ~22)
buildnotify/buildnotify/tests/test_v3_services.py (+29 -3 ~32)
buildnotify/buildnotify/tests/test_workflow_repositories.py (+0 -21 ~21)
buildnotify/buildnotify/v2_services.py (+24 -44 ~68)
buildnotify/buildnotify/v3_callbacks.py (+26 -4 ~30)
buildnotify/buildnotify/v3_jenkins.py (+28 -0 ~28)
buildnotify/buildnotify/v3_jenkins_jobs.py (+55 -1 ~56)
buildnotify/buildnotify/v3_models.py (+36 -0 ~36)
buildnotify/buildnotify/v3_services.py (+10 -5 ~15)
buildnotify/buildnotify/workflow_repositories.py (+0 -18 ~18)
buildnotify/ops/config/pillar/env.sls (+3 -0 ~3)
docs/mongodb/runbook.md (+21 -0 ~21)
gateway/Dockerfile (+1 -1 ~2)
grafana/Dockerfile (+1 -1 ~2)
grafana/OWNERS (+5 -0 ~5)
graphite/OWNERS (+5 -0 ~5)
jenkins/apitestrevisions/force_update_last_good_revision.py (+8 -17 ~25)
jenkins/apitestrevisions/get_last_good_revision.py (+1 -0 ~1)
jenkins/apitestrevisions/store_last_good_revision.py (+1 -1 ~2)
jenkins/docs/runbook.md (+1 -1 ~2)
jenkins/ops/config/states/OWNERS (+1 -0 ~1)
jenkins/ops/config/states/jenkins/config/config.xml (+13 -11 ~24)
jenkins/ops/config/states/jenkins/templates/build_image.xml (+12 -0 ~12)
jenkins/ops/orca/jenkins.sls (+9 -0 ~9)
opstools/Dockerfile (+1 -1 ~2)
opstools/OWNERS (+5 -0 ~5)
opstools/ops/orca/opstools.sls (+6 -0 ~6)
opstools/redis_tools/README.md (+48 -0 ~48)
opstools/redis_tools/redis_hot_key_tool.py (+122 -0 ~122)
orca/Dockerfile (+1 -1 ~2)
orca/pillar/aws.sls (+11 -4 ~15)
redis/ops/config/states/redis/redis_traffic_logger.py (+53 -0 ~53)
statsd/Dockerfile (+1 -1 ~2)
statsd/OWNERS (+5 -0 ~5)
vpcproxy/Dockerfile (+1 -1 ~2)
vpn/Dockerfile (+1 -1 ~2)
vpn/ops/config/states/vpn/users.yaml (+1 -1 ~2)

**33 commits:**
[weekly opsbase update (#9607)](lyft/ops_DEPRECATED@8a4fbf7)
[weekly opsbase update (#9608)](lyft/ops_DEPRECATED@3f52258)
[weekly opsbase update (#9609)](lyft/ops_DEPRECATED@e7ac9a9)
[weekly opsbase update (#9610)](lyft/ops_DEPRECATED@28c917c)
[weekly opsbase update (#9611)](lyft/ops_DEPRECATED@5d1849c)
[weekly opsbase update (#9612)](lyft/ops_DEPRECATED@4a257e6)
[weekly opsbase update (#9613)](lyft/ops_DEPRECATED@f99e037)
[weekly opsbase update (#9614)](lyft/ops_DEPRECATED@9a1d57b)
[weekly opsbase update (#9615)](lyft/ops_DEPRECATED@fc556dc)
[Send all of envoy.mongo to faststatsd (#9604)](lyft/ops_DEPRECATED@d8a243d)
[added some iam users to delete (#9617)](lyft/ops_DEPRECATED@d0daff7)
[add amartin to EngineeringVPNAccess (#9620)](lyft/ops_DEPRECATED@4831928)
[add JenkinsAccess github team (#9622)](lyft/ops_DEPRECATED@882058b)
[Providing Ikram Admin permissions (#9619)](lyft/ops_DEPRECATED@8a59730)
[restrict Jenkins access to everyone in the Dev github group (#9621)](lyft/ops_DEPRECATED@5863206)
[fixed blind orca (#9624)](lyft/ops_DEPRECATED@753a939)
[Add mareksapota-lyft to Jenkins owners (#9623)](lyft/ops_DEPRECATED@4cd2d75)
[Add envoy to help service dependencies. (#9626)](lyft/ops_DEPRECATED@a948856)
[remove EngineeringVPNAccess now that JenkinsAccess is live (#9625)](lyft/ops_DEPRECATED@670ae5f)
[Envoy 68e349852b0b1fce27378cc3278ba7560e278fa4 (#9628)](lyft/ops_DEPRECATED@cba32dc)
[add knowledgeserver service (#9627)](lyft/ops_DEPRECATED@59281f9)
[Monitor redis traffic and determine hot keys across host (#9583)](lyft/ops_DEPRECATED@e84a2a0)
[envoy 25d583413dceda484617db6fc59e8086b483df0c (#9630)](lyft/ops_DEPRECATED@674480b)
[Add minimal documentation of metrics/observability for Mongo. (#9633)](lyft/ops_DEPRECATED@eb45c33)
[OWNERS (#9634)](lyft/ops_DEPRECATED@6ae86fd)
[Fix force update script (#9635)](lyft/ops_DEPRECATED@54c7277)
[Add enterprise tables to read-only-dynamo (#9637)](lyft/ops_DEPRECATED@1416c12)
[jenkins: allow master to store artifacts in ciexec s3 (#9641)](lyft/ops_DEPRECATED@d521e16)
[Adding Jenkins Mobile to V3 buildnotify (#9631)](lyft/ops_DEPRECATED@e613e74)
[Removing V2 workflow repositories (#9638)](lyft/ops_DEPRECATED@4591dd9)
[jenkins: make build_image report to ciexec (#9642)](lyft/ops_DEPRECATED@fed3467)
[Revert "Simplifying the upstream test process" (#9644)](lyft/ops_DEPRECATED@8d0c273)
[envoy prod 4c6ee5b673dc0ed2577b3ab83a2801fa23ee36a4 (#9647)](lyft/ops_DEPRECATED@0d41d85)
NOT PASSING TESTS
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eklitzke @JeremyGrosser