This repository has been archived by the owner on May 4, 2021. It is now read-only.

Fix parsing panic if variables are not defined #269

Merged

yiranwang52 merged 3 commits into master from yiran/parsing

Sep 20, 2019

Contributor

yiranwang52 commented Sep 20, 2019

fix #266


          Fix parsing panic if variables are not defined

9ddb3b6

evelynl94 reviewed

View reviewed changes

lib/parser/dockerfile/base.go Outdated

               	if err != nil {
               		return d.err(fmt.Errorf("Failed to replace variables in input: %s", err))
               	}
+              	if len(replaced) == 0 {
+              		return d.err(fmt.Errorf("Empty args after replacing variables: %s", err))

Contributor

evelynl94 Sep 20, 2019

err is nil

Yiran Wang added 2 commits

September 19, 2019 21:14

fix

bd5bcb8

fix

c4b5232

evelynl94 approved these changes

View reviewed changes

yiranwang52 merged commit 27daadc into master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet