This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Replicator: Do not accept SetAckOffset before the cg extent is created locally #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling b94ec3a on r_race into ** on master**. |
kirg
reviewed
Jul 18, 2017
services/replicator/replicator.go
Outdated
| @@ -67,6 +67,9 @@ type ( | |||
| storehostConn map[string]*outConnection | |||
| storehostConnMutex sync.RWMutex | |||
|
|
|||
| knownCgExtents map[string]struct{} | |||
There was a problem hiding this comment.
May I suggest using the "common/set" library .. it's really just syntactic sugar, but I think it makes code look better.
kirg
reviewed
Jul 18, 2017
services/replicator/replicator.go
Outdated
| r.m3Client.IncCounter(metrics.ReplicatorSetAckOffsetScope, metrics.ReplicatorFailures) | ||
| return err | ||
| } | ||
| if len(extent.GetExtent().GetStoreUUIDs()) < 1 { |
There was a problem hiding this comment.
"ReadConsumerGroupExtent" (in the metadata client), already checks for this condition .. and returns an error. So the check here is redundant .. and will likely never be reached.
kirg
approved these changes
Jul 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.