This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
replicator fd leak: close the server stream on failure cases so that the tcp connection can be actually closed #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the tcp connection can be actually closed
kirg
reviewed
Jun 30, 2017
|
|
||
| // Must close the connection on server side because closing on client side doesn't actually close the | ||
| // underlying TCP connection | ||
| inStream.Done() |
There was a problem hiding this comment.
Probably better do a "defer inStream.Done()" immediately after the open and if-error block.
There was a problem hiding this comment.
problem is in regular cases stream is closed in the inconnection goroutine. If we do a defer, two goroutines might try to close the stream. From the websocket API the close functions are not thread-safe, also I'm not sure about the behavior of double close.
There was a problem hiding this comment.
yes, close isn't thread-safe. i see .. i hadn't noticed that; this is fine then.
|
|
||
| // Must close the connection on server side because closing on client side doesn't actually close the | ||
| // underlying TCP connection | ||
| inStream.Done() |
There was a problem hiding this comment.
defer inStream.Done() .. like above.
kirg
approved these changes
Jun 30, 2017
|
|
||
| // Must close the connection on server side because closing on client side doesn't actually close the | ||
| // underlying TCP connection | ||
| inStream.Done() |
There was a problem hiding this comment.
yes, close isn't thread-safe. i see .. i hadn't noticed that; this is fine then.
datoug
added a commit
that referenced
this pull request
Jul 10, 2017
…the tcp connection can be actually closed (#240)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title. make sure the server calls close on failure cases.