This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add input validation for cli tool #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datoug
reviewed
Jun 27, 2017
tools/common/lib.go
Outdated
| // MinConsumedMessagesRetention is the minimum consumed retention | ||
| MinConsumedMessagesRetention = 60 | ||
| // MaxConsumedMessagesRetention is the maximum consumed retention | ||
| MaxConsumedMessagesRetention = 100 * 24 * 3600 |
There was a problem hiding this comment.
I think 100 days is too long, maybe change to 30 days?
There was a problem hiding this comment.
same for unconsumed retention
tools/common/lib.go
Outdated
| // MaxUnconsumedMessagesRetention is the maximum unconsumed retention | ||
| MaxUnconsumedMessagesRetention = 100 * 24 * 3600 | ||
| // MinLockTimeoutSeconds is the minimum lock timeout seconds | ||
| MinLockTimeoutSeconds = 0 |
tools/common/lib.go
Outdated
| // MinLockTimeoutSeconds is the minimum lock timeout seconds | ||
| MinLockTimeoutSeconds = 0 | ||
| // MaxLockTimeoutSeconds is the maximum lock timeout seconds | ||
| MaxLockTimeoutSeconds = 100 * 24 * 3600 |
There was a problem hiding this comment.
This would be too long. I think generally lock timeout is in seconds. Maybe 1hr is more than enough
tools/common/lib.go
Outdated
| // MaxLockTimeoutSeconds is the maximum lock timeout seconds | ||
| MaxLockTimeoutSeconds = 100 * 24 * 3600 | ||
| // MinMaxDeliveryCount is the minimum value for max delivery count | ||
| MinMaxDeliveryCount = 0 |
tools/common/lib.go
Outdated
| // MinMaxDeliveryCount is the minimum value for max delivery count | ||
| MinMaxDeliveryCount = 0 | ||
| // MaxMaxDeliveryCount is the maximum value for max delivery count | ||
| MaxMaxDeliveryCount = math.MaxInt32 |
There was a problem hiding this comment.
we need a cap. Maybe look at all cgs on prod, and find out what's the max we're using today
datoug
approved these changes
Jun 27, 2017
tools/common/lib.go
Outdated
| // MaxUnconsumedMessagesRetention is the maximum unconsumed retention | ||
| MaxUnconsumedMessagesRetention = 7 * 24 * 3600 | ||
| // MinLockTimeoutSeconds is the minimum lock timeout seconds | ||
| MinLockTimeoutSeconds = 0 |
There was a problem hiding this comment.
I think this should be at least 10 seconds
There was a problem hiding this comment.
Sounds good. Let me update.
tools/common/lib.go
Outdated
| // MaxLockTimeoutSeconds is the maximum lock timeout seconds | ||
| MaxLockTimeoutSeconds = 3600 | ||
| // MinMaxDeliveryCount is the minimum value for max delivery count | ||
| MinMaxDeliveryCount = 0 |
There was a problem hiding this comment.
yes, just see the comment :)
datoug
pushed a commit
that referenced
this pull request
Jul 10, 2017
* Add input validation for cli tool * Add admin_mode to bypass input validation for admin tool * Update MinLockTimeoutSeconds and MinMaxDeliveryCount
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.