This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add AddPermission to AuthManager #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/auth_util.go # common/auth_util_test.go # services/frontendhost/frontend.go
|
Changes Unknown when pulling ad7b941 on security12 into ** on master**. |
|
Changes Unknown when pulling 13ab151 on security12 into ** on master**. |
|
Changes Unknown when pulling 22a77ac on security12 into ** on master**. |
datoug
approved these changes
Jun 14, 2017
common/auth_util.go
Outdated
| @@ -67,6 +68,25 @@ func GetResourceURNCreateConsumerGroup(scommon SCommon, cgPath *string) string { | |||
| return fmt.Sprintf(resourceURNTemplateCreateConsumerGroup, getTenancyLowerCase(scommon), strings.ToLower(cgPathString)) | |||
| } | |||
|
|
|||
| // GetResourceURNOperateConsumerGroup returns the resource URN to operate consumer group (read, delete), e.g. urn:cherami:dst:zone1_prod:/cg_prefix/cg1 | |||
There was a problem hiding this comment.
update comment: urn:cherami:cg:zone1_prod
services/frontendhost/frontend.go
Outdated
| @@ -647,6 +647,12 @@ func (h *Frontend) CreateDestination(ctx thrift.Context, createRequest *c.Create | |||
| return nil, err | |||
| } | |||
|
|
|||
| dstResource := common.GetResourceURNOperateDestination(h.SCommon, createRequest.Path) | |||
There was a problem hiding this comment.
can you add a comment regarding this section?
services/frontendhost/frontend.go
Outdated
| common.TagSubject: authSubject, | ||
| common.TagResource: authResource, | ||
| common.TagOperation: operation, | ||
| }).Info("Failed to add permission") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.