Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulation of shared x axis #1

Open
oschneid opened this issue May 5, 2015 · 2 comments
Open

Encapsulation of shared x axis #1

oschneid opened this issue May 5, 2015 · 2 comments
Assignees
@oschneid

Comments

@oschneid
Copy link
Collaborator

oschneid commented May 5, 2015

Right now, we are creating a d3 'xScale' object in each of the components that require it. However, this means any future changes could result in a different xScale being used (it's used in at least three components: IconVis, KeyframeEditor, and PlayHead). I need to find a way to encapsulate this.
@oschneid
Copy link
Collaborator Author

oschneid commented May 5, 2015

This also includes the information to draw the currentTime visualization (right now, the red line)

@oschneid oschneid self-assigned this May 6, 2015
@oschneid
Copy link
Collaborator Author

oschneid commented May 6, 2015

No obvious solution - leaving this for now, until I need to visually restructure the timeline

pbucci added a commit that referenced this issue Oct 5, 2015
@pbucci
Merge pull request #1 from pbucci/os-build-deploy
c536861 
Added deployment build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschneid oschneid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oschneid