Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elo library is no longer maintained, need to stop using it #1028

Open
ionparticle opened this issue Jun 23, 2022 · 0 comments
Open

elo library is no longer maintained, need to stop using it #1028

ionparticle opened this issue Jun 23, 2022 · 0 comments
Labels
code cleanup dependencies Pull requests that update a dependency file
Milestone
Flask 2

Comments

@ionparticle
Copy link
Member

elo setup requires setuptool's use_2to3, which unfortunately was deprecated and removed in setuptools v58. This will make the elo library problematic down the road, as we can't stay up setuptools <58 forever. So we need to either find another elo library or maybe just write our own implementation.
@ionparticle ionparticle added code cleanup dependencies Pull requests that update a dependency file labels Jun 23, 2022
@ionparticle ionparticle added this to the Flask 2 milestone Jun 23, 2022
ionparticle added a commit that referenced this issue Jul 26, 2022
@ionparticle
EDIT elo library now local
2d5a317 
Original library is no longer maintained and has issues with setup.py
calling use_2to3 which was removed in setuptools v58. Since we just need
elo.py, I've just copied it locally so we can skip using it as a
dependency to be installed.

Minor modifications were made:
- metaclass removed, python 3 has new syntax and it doesn't seem
necessary
- long datatype removed, python 3 no longer has long

This fixes #1028
ionparticle added a commit that referenced this issue Jul 26, 2022
@ionparticle
EDIT elo library now local
71c6c8e 
Original library is no longer maintained and has issues with setup.py
calling use_2to3 which was removed in setuptools v58. Since we just need
elo.py, I've just copied it locally so we can skip using it as a
dependency to be installed.

Minor modifications were made:
- metaclass removed, python 3 has new syntax and it doesn't seem
necessary
- long datatype removed, python 3 no longer has long

This fixes #1028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Flask 2
Development

No branches or pull requests
1 participant
@ionparticle