Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Workflows #82

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Github Workflows #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
bf76d42
starting workflow?
senkevinli Oct 27, 2020
68bfd37
fixed syntax
senkevinli Oct 27, 2020
f2658da
trying matrix
senkevinli Oct 27, 2020
e4d9210
fixed typo
senkevinli Oct 27, 2020
d9d901d
added testing stage
senkevinli Oct 28, 2020
502c057
fixed typo in ci.yaml
senkevinli Oct 28, 2020
1ea1420
removed tty
senkevinli Oct 28, 2020
1fc815f
pinning aiohttp for now
senkevinli Oct 29, 2020
edf93df
adjusting tty in makefiles
senkevinli Oct 29, 2020
04b0cb6
updating python version
senkevinli Oct 29, 2020
cc752a0
added more tests
senkevinli Oct 29, 2020
05e9042
changing options again
senkevinli Oct 29, 2020
c11a287
changed python environment
senkevinli Oct 29, 2020
28b4b8e
syntax fix
senkevinli Oct 29, 2020
46418fd
factored out tests to jobs
senkevinli Oct 29, 2020
c0ddd6c
fixed syntax again
senkevinli Oct 29, 2020
fd092ba
fixed setup
senkevinli Oct 29, 2020
fe11c05
added another workflow for xavier
senkevinli Jan 11, 2021
4789522
bring in master changes
senkevinli Feb 25, 2021
67a7aa5
fix typo + add image-rec-auto
senkevinli Feb 25, 2021
43d6a0c
it option to image-rec-auto makefile
senkevinli Feb 25, 2021
afb9e42
solve issue with imagery tests
senkevinli Feb 25, 2021
e4428dd
delete prod.yaml + get rid of clean up
senkevinli Feb 28, 2021
aeaec7e
stop redundant checks
senkevinli Feb 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/imagery/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"start": "node ./bin/start-service",
"build": "babel src --out-dir lib",
"build-msg": "mkdir -p lib && pbjs -t static-module --es6 --keep-case -o src/messages.js src/messages/*.proto",
"test": "jest",
"test": "jest --runInBand",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves issue of test flakiness mentioned in #59. Jest by default runs tests in parallel, so multiple tests were modifying the sqlite file at the same time (hence the unexplained behavior of rolling back a transaction that wasn't underway).

"lint": "eslint src test --ignore-pattern src/messages.js"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion services/imagery/src/backends/sync-backend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default class SyncBackend {
const { body: msg } =
await request.get(this._syncUrl + '/api/available')
.proto(imagery.AvailableImages)
.timeout(5000);
.timeout(3000);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 second timeout is causing some tests to fail intermittently.


return msg.id_list;
}
Expand Down