Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very long filenames overrun the left column and push into the main column in Firefox #710 #980

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Very long filenames overrun the left column and push into the main column in Firefox #710 #980

merged 3 commits into from
Jan 15, 2019

Conversation

ConnorSheremeta
Copy link
Contributor

@ConnorSheremeta ConnorSheremeta commented Jan 14, 2019 •
edited
Loading

#710

Screenshots of this fix on Firefox with different screen widths:

pr980ss

murny
murny suggested changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Make sure you add a changelog entry however! Then I can approve

Also its nice to add screenshots to your description to help reviewers see the change (quick screenshot showing this is fixed in firefox would be really nice for example)

murny
murny approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ConnorSheremeta ConnorSheremeta merged commit fdbe07f into ualbertalib:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murny murny murny approved these changes

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConnorSheremeta @murny