Small improvements for flapping tests #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change comment about default sort add assertion before advancing
weiweishi
reviewed
Sep 27, 2018
| @@ -245,7 +245,8 @@ def before_all | |||
| click_button 'Search' | |||
| assert_equal URI.parse(current_url).request_uri, search_path(search: 'Fancy') | |||
|
|
|||
| # Default sort is by title | |||
| # Default sort is by relevance | |||
| # TODO this test has flapped in the past because the score of each document is equal | |||
There was a problem hiding this comment.
Would you be changing this test this round? Or this is a to-do for future note?
There was a problem hiding this comment.
It's a todo for future note.
weiweishi
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#811