Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.65.1 to 1.67.0 #3587

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 15, 2024

Bumps rubocop from 1.65.1 to 1.67.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.67

New features

  • #13259: Add new Lint/DuplicateSetElement cop. ([@​koic][])
  • #13223: Add AllowRBSInlineAnnotation config option to Layout/LeadingCommentSpace to support RBS::Inline style annotation comments. ([@​tk0miya][])
  • #13310: Display analysis Ruby version in rubocop -V. ([@​koic][])

Bug fixes

  • #13314: Fix a false negative for Style/Semicolon when using a semicolon between a closing parenthesis after a line break and a consequent expression. ([@​koic][])
  • #13217: Fix a false positive in Lint/ParenthesesAsGroupedExpression with compound ranges. ([@​gsamokovarov][])
  • #13268: Fix a false positive for Style/BlockDelimiters when a single line do-end block with an inline rescue with a semicolon before rescue. ([@​koic][])
  • #13298: Fix an error for Layout/AccessModifierIndentation when the access modifier is on the same line as the class definition. ([@​koic][])
  • #13198: Fix an error for Style/OneLineConditional when using nested if/then/else/end. ([@​koic][])
  • #13316: Fix an incorrect autocorrect for Lint/ImplicitStringConcatenation with Lint/TripleQuotes when string literals with triple quotes are used. ([@​koic][])
  • #13220: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using only forwarded arguments in brackets. ([@​koic][])
  • #13202: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data with different block variable names. ([@​koic][])
  • #13291: Fix an incorrect autocorrect for Style/RescueModifier when using modifier rescue for method call with heredoc argument. ([@​koic][])
  • #13226: Fix --auto-gen-config when passing an absolute config path. ([@​earlopain][])
  • #13225: Avoid syntax error when correcting Style/OperatorMethodCall with / operations followed by a parenthesized argument. ([@​dvandersluis][])
  • #13235: Fix an error for Style/IfUnlessModifier when multiline if that fits on one line and using implicit method call with hash value omission syntax. ([@​koic][])
  • #13219: Fix a false positive for Style/ArgumentsForwarding with Ruby 3.0 and optional position arguments. ([@​earlopain][])
  • #13271: Fix a false positive for Lint/AmbiguousRange when using rational literals. ([@​koic][])
  • #13260: Fix a false positive for Lint/RedundantSafeNavigation with namespaced constants. ([@​earlopain][])
  • #13224: Fix false positives for Style/OperatorMethodCall with named forwarding. ([@​earlopain][])
  • #13213: Fix false positives for Style/AccessModifierDeclarations when AllowModifiersOnAttrs: true and using splat with a percent symbol array, or with a constant. ([@​koic][])
  • #13145: Fix false positives for Style/RedundantLineContinuation when line continuations with comparison operator and the LHS is wrapped in parentheses. ([@​koic][])
  • #12875: Fix false positive for Style/ArgumentsForwarding when argument is used inside a block. ([@​dvandersluis][])
  • #13239: Fix false positive for Style/CollectionCompact when using delete_if. ([@​masato-bkn][])
  • #13210: Fix omit_parentheses style for pattern match with value omission in single-line branch. ([@​gsamokovarov][])
  • #13149: Handle crashes in custom Ruby extractors more gracefully. ([@​earlopain][])
  • #13319: Handle literal forward slashes inside a regexp in Lint/LiteralInInterpolation. ([@​dvandersluis][])
  • #13208: Fix an incorrect autocorrect for Style/IfWithSemicolon when single-line if/;/end when the then body contains a method call with [] or []=. ([@​koic][])
  • #13318: Prevent modifying blocks with Style/HashEachMethods if the hash is modified within the block. ([@​dvandersluis][])
  • #13293: Fix TargetRubyVersion from a gemspec when the gemspec is not named like the folder it is located in. ([@​earlopain][])
  • #13211: Fix wrong autocorrect for Style/GuardClause when using heredoc without else branch. ([@​earlopain][])
  • #13215: Fix wrong autocorrect for Lint/BigDecimalNew when using ::BigDecimal.new. ([@​earlopain][])
  • #13215: Fix wrong autocorrect for Style/MethodCallWithArgsParentheses with EnforcedStyle: omit_parentheses and whitespace. ([@​earlopain][])
  • #13302: Fix incompatible autocorrect between Style/RedundantBegin and Style/BlockDelimiters with EnforcedStyle: braces_for_chaining. ([@​earlopain][])

Changes

  • #13221: Do not group accessors having RBS::Inline annotation comments in Style/AccessorGrouping. ([@​tk0miya][])
  • #13286: Add AllowedMethods configuration to Layout/FirstMethodArgumentLineBreak. ([@​dvandersluis][])
  • #13110: Add support in Style/ArgumentsForwarding for detecting forwarding of all anonymous arguments. ([@​dvandersluis][])
  • #13222: Allow to write RBS::Inline annotation comments after method definition in Style/CommentedKeyword. ([@​tk0miya][])
  • #13253: Emit a deprecation when custom cops inherit from RuboCop::Cop::Cop. ([@​earlopain][])
  • #13300: Set EnforcedShorthandSyntax: either by default for Style/HashSyntax. ([@​koic][])
  • #13254: Enhance the autocorrect for Naming/InclusiveLanguage when a sole suggestion is set. ([@​koic][])
  • #13232: Make server mode aware of auto-restart for local config update. ([@​koic][])

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.67.0 (2024-10-15)

New features

  • #13259: Add new Lint/DuplicateSetElement cop. ([@​koic][])
  • #13223: Add AllowRBSInlineAnnotation config option to Layout/LeadingCommentSpace to support RBS::Inline style annotation comments. ([@​tk0miya][])
  • #13310: Display analysis Ruby version in rubocop -V. ([@​koic][])

Bug fixes

  • #13314: Fix a false negative for Style/Semicolon when using a semicolon between a closing parenthesis after a line break and a consequent expression. ([@​koic][])
  • #13217: Fix a false positive in Lint/ParenthesesAsGroupedExpression with compound ranges. ([@​gsamokovarov][])
  • #13268: Fix a false positive for Style/BlockDelimiters when a single line do-end block with an inline rescue with a semicolon before rescue. ([@​koic][])
  • #13298: Fix an error for Layout/AccessModifierIndentation when the access modifier is on the same line as the class definition. ([@​koic][])
  • #13198: Fix an error for Style/OneLineConditional when using nested if/then/else/end. ([@​koic][])
  • #13316: Fix an incorrect autocorrect for Lint/ImplicitStringConcatenation with Lint/TripleQuotes when string literals with triple quotes are used. ([@​koic][])
  • #13220: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using only forwarded arguments in brackets. ([@​koic][])
  • #13202: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data with different block variable names. ([@​koic][])
  • #13291: Fix an incorrect autocorrect for Style/RescueModifier when using modifier rescue for method call with heredoc argument. ([@​koic][])
  • #13226: Fix --auto-gen-config when passing an absolute config path. ([@​earlopain][])
  • #13225: Avoid syntax error when correcting Style/OperatorMethodCall with / operations followed by a parenthesized argument. ([@​dvandersluis][])
  • #13235: Fix an error for Style/IfUnlessModifier when multiline if that fits on one line and using implicit method call with hash value omission syntax. ([@​koic][])
  • #13219: Fix a false positive for Style/ArgumentsForwarding with Ruby 3.0 and optional position arguments. ([@​earlopain][])
  • #13271: Fix a false positive for Lint/AmbiguousRange when using rational literals. ([@​koic][])
  • #13260: Fix a false positive for Lint/RedundantSafeNavigation with namespaced constants. ([@​earlopain][])
  • #13224: Fix false positives for Style/OperatorMethodCall with named forwarding. ([@​earlopain][])
  • #13213: Fix false positives for Style/AccessModifierDeclarations when AllowModifiersOnAttrs: true and using splat with a percent symbol array, or with a constant. ([@​koic][])
  • #13145: Fix false positives for Style/RedundantLineContinuation when line continuations with comparison operator and the LHS is wrapped in parentheses. ([@​koic][])
  • #12875: Fix false positive for Style/ArgumentsForwarding when argument is used inside a block. ([@​dvandersluis][])
  • #13239: Fix false positive for Style/CollectionCompact when using delete_if. ([@​masato-bkn][])
  • #13210: Fix omit_parentheses style for pattern match with value omission in single-line branch. ([@​gsamokovarov][])
  • #13149: Handle crashes in custom Ruby extractors more gracefully. ([@​earlopain][])
  • #13319: Handle literal forward slashes inside a regexp in Lint/LiteralInInterpolation. ([@​dvandersluis][])
  • #13208: Fix an incorrect autocorrect for Style/IfWithSemicolon when single-line if/;/end when the then body contains a method call with [] or []=. ([@​koic][])
  • #13318: Prevent modifying blocks with Style/HashEachMethods if the hash is modified within the block. ([@​dvandersluis][])
  • #13293: Fix TargetRubyVersion from a gemspec when the gemspec is not named like the folder it is located in. ([@​earlopain][])
  • #13211: Fix wrong autocorrect for Style/GuardClause when using heredoc without else branch. ([@​earlopain][])
  • #13215: Fix wrong autocorrect for Lint/BigDecimalNew when using ::BigDecimal.new. ([@​earlopain][])
  • #13215: Fix wrong autocorrect for Style/MethodCallWithArgsParentheses with EnforcedStyle: omit_parentheses and whitespace. ([@​earlopain][])
  • #13302: Fix incompatible autocorrect between Style/RedundantBegin and Style/BlockDelimiters with EnforcedStyle: braces_for_chaining. ([@​earlopain][])

Changes

  • #13221: Do not group accessors having RBS::Inline annotation comments in Style/AccessorGrouping. ([@​tk0miya][])
  • #13286: Add AllowedMethods configuration to Layout/FirstMethodArgumentLineBreak. ([@​dvandersluis][])
  • #13110: Add support in Style/ArgumentsForwarding for detecting forwarding of all anonymous arguments. ([@​dvandersluis][])
  • #13222: Allow to write RBS::Inline annotation comments after method definition in Style/CommentedKeyword. ([@​tk0miya][])
  • #13253: Emit a deprecation when custom cops inherit from RuboCop::Cop::Cop. ([@​earlopain][])
  • #13300: Set EnforcedShorthandSyntax: either by default for Style/HashSyntax. ([@​koic][])
  • #13254: Enhance the autocorrect for Naming/InclusiveLanguage when a sole suggestion is set. ([@​koic][])

... (truncated)

Commits
  • c108ac0 Cut 1.67
  • 74ddd9b Update Changelog
  • b5c12ae Update Changelog
  • c936160 [Fix #13331] Fix an error when using release task
  • 60ecb00 [Fix #13328] Declare Enabled as a common config key
  • 99022d9 Merge pull request #13327 from koic/make_server_mode_aware_of_auto_restart_fo...
  • 60432f5 Apply RESTRICT_ON_SEND to Bundler/GemVersion
  • 6b31c39 Make server mode aware of auto-restart for .rubocop_todo.yml update
  • adb7cee [Fix #9816] Refine Lint/SafeNavigationConsistency
  • 7d6797c [Fix #13286] Add AllowedMethods and AllowedPatterns configuration to `Lay...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from lagoan as a code owner October 15, 2024 16:29
@dependabot dependabot bot added the ruby Pull requests that update Ruby code label Oct 15, 2024
@dependabot dependabot bot requested a review from pgwillia as a code owner October 15, 2024 16:29
@dependabot dependabot bot force-pushed the dependabot/bundler/main/rubocop-1.67.0 branch 3 times, most recently from 1783e55 to 8d6e345 Compare October 21, 2024 22:28
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.65.1 to 1.67.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.65.1...v1.67.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/main/rubocop-1.67.0 branch from 8d6e345 to 2d12925 Compare October 21, 2024 22:48
Copy link
Member

@pgwillia pgwillia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changelog for mentions that match our cops

@pgwillia pgwillia merged commit 95e8f34 into main Oct 21, 2024
2 checks passed
@pgwillia pgwillia deleted the dependabot/bundler/main/rubocop-1.67.0 branch October 21, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant