Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.25.1 to 2.26.2 #3576

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024

Bumps rubocop-rails from 2.25.1 to 2.26.2.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.26.2

Bug fixes

  • #1362: Fix false positives for Rails/EnumSyntax when using Ruby 2.7. (@​koic)
  • #1269: Fix false positives for Rails/ActionControllerFlashBeforeRender in combination with implicit returns. (@​earlopain)
  • #1326: Fix wrong autocorrect for Rails/FilePath when passing an array to File.join. (@​earlopain)

Changes

RuboCop Rails 2.26.1

Bug fixes

  • #1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. (@​earlopain)
  • #1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. (@​earlopain)

Changes

RuboCop Rails 2.26.0

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@​earlopain)
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@​earlopain)
  • #1337: Fix an error for Rails/Validation when passing no arguments. (@​earlopain)
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@​earlopain)
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. ([@​tldn0718][])
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@​koic)
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@​earlopain)
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. (@​earlopain)
  • #1302: Allow params receiver by default for Style/CollectionMethods. (@​koic)
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@​earlopain)

Changes

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.26.2 (2024-09-21)

Bug fixes

  • #1362: Fix false positives for Rails/EnumSyntax when using Ruby 2.7. ([@​koic][])
  • #1269: Fix false positives for Rails/ActionControllerFlashBeforeRender in combination with implicit returns. ([@​earlopain][])
  • #1326: Fix wrong autocorrect for Rails/FilePath when passing an array to File.join. ([@​earlopain][])

Changes

2.26.1 (2024-09-07)

Bug fixes

  • #1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. ([@​earlopain][])
  • #1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. ([@​earlopain][])

Changes

2.26.0 (2024-08-24)

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. ([@​earlopain][])
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. ([@​earlopain][])
  • #1337: Fix an error for Rails/Validation when passing no arguments. ([@​earlopain][])
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. ([@​earlopain][])
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. ([@​tldn0718][])
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. ([@​koic][])
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. ([@​earlopain][])
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. ([@​earlopain][])
  • #1302: Allow params receiver by default for Style/CollectionMethods. ([@​koic][])
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). ([@​earlopain][])

Changes

... (truncated)

Commits
  • f646d6e Cut 2.26.2
  • a451135 Update Changelog
  • f935a0b Suppress new RuboCop offenses
  • 4a00257 Merge pull request #1326 from Earlopain/wrong-autocorrect-for-rails-file-path
  • 38cec18 [Doc] Sync the Rails configuration tip with the README
  • 5dc42d5 Merge pull request #1363 from koic/fix_false_positives_for_rails_enum_syntax
  • 50fe9a7 [Fix #1362] Fix false positives for Rails/EnumSyntax
  • 210f42e Merge pull request #1344 from Earlopain/revert-1311
  • 5e66785 Merge pull request #1361 from masato-bkn/fix-rails-compact-blank
  • f4f3bf1 Fix Rails/CompactBlank to avoid reporting offense for filter in Ruby vers...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Sep 23, 2024
@dependabot dependabot bot force-pushed the dependabot/bundler/main/rubocop-rails-2.26.2 branch from 6e152b7 to 3607549 Compare October 2, 2024 15:12
@dependabot dependabot bot force-pushed the dependabot/bundler/main/rubocop-rails-2.26.2 branch 5 times, most recently from fbd93fa to 9ceb216 Compare October 21, 2024 22:48
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.25.1 to 2.26.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.25.1...v2.26.2)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/main/rubocop-rails-2.26.2 branch from 9ceb216 to b4de3e4 Compare October 21, 2024 22:55
Copy link

github-actions bot commented Oct 21, 2024

1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by 🚫 Danger

Enum defined with keyword arguments in enum declarations. Use positional arguments instead.

https://devdocs.io/rails~7.1/activerecord/enum
@pgwillia pgwillia force-pushed the dependabot/bundler/main/rubocop-rails-2.26.2 branch from 8735703 to b0e3a0a Compare October 21, 2024 23:32
@pgwillia pgwillia merged commit 7f236b6 into main Oct 21, 2024
3 checks passed
@pgwillia pgwillia deleted the dependabot/bundler/main/rubocop-rails-2.26.2 branch October 21, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant