Update changelog and bump version file #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murny
requested review from
ConnorSheremeta,
jefferya,
lagoan and
pgwillia
as code owners
murny
force-pushed
the
cut-new-release-for-v2.9.0
branch
from
8bc2e5f
to
00b0823
Compare
pgwillia
approved these changes
Mar 14, 2024
| ### Fixed | ||
| * Prevent theses and items sitemap views from using the same cache key [#3361](https://github.com/ualbertalib/jupiter/pull/3400) | ||
| * Prevent theses and items sitemap views from using the same cache key [PR#3400](https://github.com/ualbertalib/jupiter/pull/3400) |
There was a problem hiding this comment.
#3361 is the issue the PR resolves. Do we have a preference? I'm good as long as the label/link are in agreement.
There was a problem hiding this comment.
I think if you look at the changelog, we almost always link to the pull request with the text of the link being like PR#9999.
So here, the href was to the PR, but the text was to the issue, so just updated the text to match.
Have no preference myself, just as long as the text takes you where it says.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This will update our changelog and version file to get ready to cut a release for v2.9.0 for Jupiter.
The big change here is bumping Rails up from v7.0 to v7.1.