Remove fully enabled feature flags that have been enabled for years #3375
Conversation
| @@ -3,24 +3,10 @@ | |||
| class SolrBadRequestTest < ActionDispatch::IntegrationTest | |||
|
|
|||
| test 'request in which solr gives 400 gives a proper response' do | |||
| get search_url, params: { facets: { all_subjects_sim: ['Antimicrobial', '"blown-pack"'] } } | |||
There was a problem hiding this comment.
These are passing now, so might have to do with :or_facets feature flag being enabled now.
The only one failing now is the last one which had special characters ("\"\\'Bacteriocins").
So I assume it was failing before because we passing an array or a hash with multiple values and now with :or_facets feature flag being always enabled this is okay?
So just simplify the test and added a comment on what we are actually testing here.
murny
requested review from
ConnorSheremeta,
jefferya,
lagoan and
pgwillia
as code owners
There was a problem hiding this comment.
I spoke with @leahvanderjagt yesterday about this change. She agrees that these are all behaviours we want to keep long term. 👍
Really good work to keep our code clean so what we're maintaining is as simple as possible!
|
@pgwillia Awesome, thanks for confirming with Leah 🙏 |
CHANGELOG.md
Outdated
| @@ -9,6 +9,9 @@ New entries in this file should aim to provide a meaningful amount of informatio | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Removed | |||
| - Remove fully enabled feature flags that have been enabled for years [PR#3375](https://github.com/ualbertalib/jupiter/pull/3375) | |||
| - | |||
There was a problem hiding this comment.
Small formatting error from the rebase
There was a problem hiding this comment.
oops good catch, will fix this
#3277
This PR removes all the fully enabled feature flags that have been enabled for years:
datacite_apiflag was removed here: #3277or_facts feature flagI think is a duplicate and probably never workedNote: There may be good reason to keep these flags around, such as being able to quickly switch back to old behaviour for some reason? So if so, let me know and we can unremoved these.
After this is merged, we will have to remove these from Flipper UI in production as well.