Bump flipper-ui, flipper and flipper-active_record #3348
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
ConnorSheremeta,
jefferya,
lagoan,
murny and
pgwillia
as code owners
dependabot
bot
force-pushed
the
dependabot/bundler/master/flipper-ui-and-flipper-and-flipper-active_record-1.2.2
branch
7 times, most recently
from
75aaf8f
to
8e22b0c
Compare
dependabot
bot
force-pushed
the
dependabot/bundler/master/flipper-ui-and-flipper-and-flipper-active_record-1.2.2
branch
6 times, most recently
from
3413abf
to
a8d799e
Compare
Bumps [flipper-ui](https://github.com/flippercloud/flipper), [flipper](https://github.com/flippercloud/flipper) and [flipper-active_record](https://github.com/flippercloud/flipper). These dependencies needed to be updated together. Updates `flipper-ui` from 1.0.0 to 1.2.2 - [Release notes](https://github.com/flippercloud/flipper/releases) - [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md) - [Commits](flippercloud/flipper@v1.0.0...v1.2.2) Updates `flipper` from 1.0.0 to 1.2.2 - [Release notes](https://github.com/flippercloud/flipper/releases) - [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md) - [Commits](flippercloud/flipper@v1.0.0...v1.2.2) Updates `flipper-active_record` from 1.0.0 to 1.2.2 - [Release notes](https://github.com/flippercloud/flipper/releases) - [Changelog](https://github.com/flippercloud/flipper/blob/main/Changelog.md) - [Commits](flippercloud/flipper@v1.0.0...v1.2.2) --- updated-dependencies: - dependency-name: flipper-ui dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: flipper dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: flipper-active_record dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/master/flipper-ui-and-flipper-and-flipper-active_record-1.2.2
branch
from
a8d799e
to
4fc6065
Compare
| @@ -0,0 +1,18 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
This comes from bin/rails g flipper:update which applies this new migration https://github.com/flippercloud/flipper/blob/main/lib/generators/flipper/templates/update/migrations/02_change_flipper_gates_value_to_text.rb.erb
Kinda surprised this wasn't flagged as unsafe by strong migrations? https://github.com/ankane/strong_migrations?tab=readme-ov-file#changing-the-type-of-a-column
But this should be safe to run as is, as this table only has 6 values in the table and should be super quick to run.
We could probably also tackle this issue beforehand to make sure theirs nothing reading from this table as all feature flags have been fully enabled for a very long time now: #3277
There was a problem hiding this comment.
This table should have no data in it now, since #3277 is now completed. So should be no real concern here for this migration.
…lipper-and-flipper-active_record-1.2.2
…lipper-and-flipper-active_record-1.2.2
…lipper-and-flipper-active_record-1.2.2
…lipper-and-flipper-active_record-1.2.2
| remove_index :flipper_gates, [:feature_key, :key, :value] | ||
| end | ||
| change_column :flipper_gates, :value, :text | ||
| add_index :flipper_gates, [:feature_key, :key, :value], unique: true, length: { value: 255 } |
There was a problem hiding this comment.
A question from my curiousness, is length: { value: 255 } meant only to guard against an overly large index entry or does it server another purpose?
There was a problem hiding this comment.
Yeah, that's a great question.
Apparently this only works for Mysql so makes no difference to us in Jupiter as we use Postgres. This is confirmed in the original PR for this migration here: flippercloud/flipper#790 (comment)
Mysql if you are indexing a text column (which this value column is after this migration) it wants you to set a length I guess as mentioned in these docs: https://dev.mysql.com/doc/refman/8.0/en/create-index.html#create-index-column-prefixes
Otherwise, Mysql will throw errors at you which happen to this Flipper project in here: flippercloud/flipper#789
As for why Mysql has this limitation, perhaps this stack overflow can shed some light: https://stackoverflow.com/a/1827099
…lipper-and-flipper-active_record-1.2.2
murny
deleted the
dependabot/bundler/master/flipper-ui-and-flipper-and-flipper-active_record-1.2.2
branch
Bumps flipper-ui, flipper and flipper-active_record. These dependencies needed to be updated together.
Updates
flipper-uifrom 1.0.0 to 1.2.2Release notes
Sourced from flipper-ui's releases.
... (truncated)
Commits
dd54868Release 1.2.2e947540Merge pull request #827 from flippercloud/test-help-fixesbcafbc4Reconfigure in integration test68e2f73TestHelp: Reconfigure once, remove all features before each test6384a80Merge pull request #820 from flippercloud/stop-global-warming5df0121Merge remote-tracking branch 'origin/main' into stop-global-warming52c47e4Merge pull request #824 from flippercloud/cli-bundler-colorize12eef0eTest colorization in specsd0c4ba7Merge remote-tracking branch 'origin/main' into cli-bundler-colorize8ba0b5cTry increasing process_timeout on system testUpdates
flipperfrom 1.0.0 to 1.2.2Release notes
Sourced from flipper's releases.
... (truncated)
Commits
dd54868Release 1.2.2e947540Merge pull request #827 from flippercloud/test-help-fixesbcafbc4Reconfigure in integration test68e2f73TestHelp: Reconfigure once, remove all features before each test6384a80Merge pull request #820 from flippercloud/stop-global-warming5df0121Merge remote-tracking branch 'origin/main' into stop-global-warming52c47e4Merge pull request #824 from flippercloud/cli-bundler-colorize12eef0eTest colorization in specsd0c4ba7Merge remote-tracking branch 'origin/main' into cli-bundler-colorize8ba0b5cTry increasing process_timeout on system testUpdates
flipper-active_recordfrom 1.0.0 to 1.2.2Release notes
Sourced from flipper-active_record's releases.
... (truncated)
Commits
dd54868Release 1.2.2e947540Merge pull request #827 from flippercloud/test-help-fixesbcafbc4Reconfigure in integration test68e2f73TestHelp: Reconfigure once, remove all features before each test6384a80Merge pull request #820 from flippercloud/stop-global-warming5df0121Merge remote-tracking branch 'origin/main' into stop-global-warming52c47e4Merge pull request #824 from flippercloud/cli-bundler-colorize12eef0eTest colorization in specsd0c4ba7Merge remote-tracking branch 'origin/main' into cli-bundler-colorize8ba0b5cTry increasing process_timeout on system testYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)