Webpacker migration #3320
Merged
Webpacker migration #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
murny
force-pushed
the
webpacker-migration
branch
from
a69d3b6
to
1aaaf24
Compare
murny
force-pushed
the
Rails-7-upgrade
branch
from
3f72982
to
1ddbf8d
Compare
murny
commented
Jan 26, 2024
murny
commented
Jan 26, 2024
murny
commented
Jan 26, 2024
murny
requested review from
ConnorSheremeta,
jefferya,
lagoan and
pgwillia
as code owners
murny
commented
Jan 26, 2024
murny
commented
Jan 26, 2024
murny
commented
Jan 28, 2024
| @@ -4,36 +4,32 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "lint": "eslint --ext .js app/javascript", | |||
| "lint-css": "stylelint \"app/javascript/**/*.scss\"" | |||
| "lint-css": "stylelint \"app/assets/stylesheets/**/*.scss\"", | |||
| "build": "esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds --public-path=/assets", | |||
There was a problem hiding this comment.
I am getting these warnings:
WARN -- : Removed sourceMappingURL comment for missing asset '/assets/admin.js.map' from /app/app/assets/builds/admin.js
WARN -- : Removed sourceMappingURL comment for missing asset '/assets/application.js.map' from /app/app/assets/builds/application.js
Which go away when omitting the --public-path=/assets flag. I believe this is an issue upstream however which should be resolved here: rails/sprockets-rails#515
There was a problem hiding this comment.
Interesting. From reading those issues, sounds like we want --public-path=/asset as this allows static assets like images to be loaded from JS (see here rails/jsbundling-rails#58)
So I rather break sourcemaps (which is for debugging) a bit over breaking this serving static assets from JS? Looks like it got fixed in propshaft, so hopefully theirs a fix for this in the future.
murny
force-pushed
the
webpacker-migration
branch
from
f69b3d5
to
27ffc03
Compare
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
murny
commented
Feb 10, 2024
| proxy_pass http://jupiter; | ||
|
|
||
| # limit_req zone=one; | ||
| access_log /var/log/nginx.access.log; | ||
| error_log /var/log/nginx.error.log; | ||
| } | ||
|
|
||
| location ^~ /packs/ { | ||
| location ~ ^/assets/ { |
There was a problem hiding this comment.
Updated this and just used https://guides.rubyonrails.org/asset_pipeline.html#far-future-expires-header as a reference.
|
K think I updated and answered everything from feedback. Thanks for the through review, Connor 🙏. |
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
app/assets/builds/admin.js.map
Outdated
| { | ||
| "version": 3, | ||
| "sources": ["../../javascript/src/admin/ajax_table.js", "../../javascript/src/admin/new_batch_ingest.js"], | ||
| "sourcesContent": ["document.addEventListener('turbolinks:load', () => {\n function renderNewTable() {\n const $form = $(this).closest('form');\n let action = $form.attr('action');\n if (!action) {\n action = window.location.href;\n }\n $.get(action, $form.serialize(), null, 'script');\n return false;\n }\n\n function ajaxLink() {\n $.getScript(this.href);\n return false;\n }\n // Fetch new table for autocomplete and filter widgets\n $('.js-autocomplete select').change(renderNewTable);\n\n // TODO: Could be improved. Should maybe bring in a `debounce` function for this search\n $('.js-autocomplete input').keyup(renderNewTable);\n\n // Sorting and pagination links\n $('#js-ajax-table').on('click', ' th a.sort_link, .pagination a', ajaxLink);\n});\n", "/* eslint-disable no-undef */\n\nfunction addFileInput(id, name) {\n if (\n $('.js-batch-ingest-files-list').find(`input[value='${id}']`).length === 0\n ) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[batch_ingest_files_attributes][][google_file_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-files-list').append(input);\n }\n}\n\nfunction addSpreadsheetInput(id, name) {\n const input = `<li class=\"list-group-item d-flex justify-content-between\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_name]\" value=\"${name}\">\n <input type=\"hidden\" name=\"batch_ingest[google_spreadsheet_id]\" value=\"${id}\">\n ${name}\n <button type=\"button\" class=\"btn btn-danger btn-sm js-btn-delete-file\">\n <i class=\"fa fa-trash-alt\" aria-hidden=\"true\"></i> Delete\n </button>\n </li>`;\n\n $('.js-batch-ingest-spreadsheet').append(input);\n $('.js-btn-spreadsheet').addClass('d-none');\n}\n\nfunction deleteFileFromFilesList() {\n $(this).closest('li').remove();\n}\n\nfunction deleteSpreadsheet() {\n $(this).closest('li').remove();\n $('.js-btn-spreadsheet').removeClass('d-none');\n}\n\nfunction pickerFilesCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n data.docs.forEach((doc) => {\n addFileInput(doc.id, doc.name);\n });\n }\n}\n\nfunction pickerSpreadsheetCallback(data) {\n if (data.action === google.picker.Action.PICKED) {\n addSpreadsheetInput(data.docs[0].id, data.docs[0].name);\n }\n}\n\nfunction createFilesPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.DocsView(google.picker.ViewId.DOCS);\n view.setMimeTypes(\n 'application/epub+zip,'\n + 'application/excel,'\n + 'application/gzip,'\n + 'application/json,'\n + 'application/mp4,'\n + 'application/msword,'\n + 'application/octet-stream,'\n + 'application/pdf,'\n + 'application/postscript,'\n + 'application/rtf,'\n + 'application/sql,'\n + 'application/vnd.android.package-archive,'\n + 'application/vnd.ms-access,'\n + 'application/vnd.ms-asf,'\n + 'application/vnd.ms-excel,'\n + 'application/vnd.ms-excel.sheet.binary.macroenabled.12,'\n + 'application/vnd.ms-excel.sheet.macroenabled.12,'\n + 'application/vnd.ms-powerpoint,'\n + 'application/vnd.oasis.opendocument.text,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.presentation,'\n + 'application/vnd.openxmlformats-officedocument.presentationml.slideshow,'\n + 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.document,'\n + 'application/vnd.openxmlformats-officedocument.wordprocessingml.template,'\n + 'application/x-7z-compressed,'\n + 'application/x-bibtex,'\n + 'application/x-bibtex-text-file,'\n + 'application/x-ole-storage,'\n + 'application/x-rar,'\n + 'application/x-rar-compressed,'\n + 'application/x-spss-sav,'\n + 'application/x-tar,'\n + 'application/x-xz,'\n + 'application/x-zip-compressed,'\n + 'application/xml,'\n + 'application/zip,'\n + 'audio/mp4,'\n + 'audio/mpeg,'\n + 'audio/vnd.wave,'\n + 'audio/wav,'\n + 'audio/x-m4a,'\n + 'audio/x-mpegurl,'\n + 'audio/x-ms-asx,'\n + 'audio/x-ms-wma,'\n + 'audio/x-ms-wmv,'\n + 'audio/x-wav,'\n + 'audio/x-wave,'\n + 'image/gif,'\n + 'image/jpeg,'\n + 'image/png,'\n + 'image/svg+xml,'\n + 'image/tiff,'\n + 'inode/x-empty,'\n + 'message/rfc822,'\n + 'text/comma-separated-values,'\n + 'text/csv,'\n + 'text/html,'\n + 'text/plain,'\n + 'text/rtf,'\n + 'text/x-bibtex,'\n + 'text/x-csrc,'\n + 'text/x-matlab,'\n + 'text/x-objcsrc,'\n + 'text/x-r-source,'\n + 'text/x-r-sweave,'\n + 'video/mp4,'\n + 'video/mpeg,'\n + 'video/quicktime,'\n + 'video/x-flv,'\n + 'video/x-m4v,'\n + 'video/x-ms-wmv,'\n + 'video/x-msvideo',\n );\n view.setIncludeFolders(true);\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a file(s)')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .enableFeature(google.picker.Feature.MULTISELECT_ENABLED)\n .enableFeature(google.picker.Feature.SUPPORT_DRIVES)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerFilesCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction createSpreadsheetPicker() {\n const { developerKey, accessToken } = this.dataset;\n\n if (accessToken && developerKey) {\n const view = new google.picker.View(google.picker.ViewId.SPREADSHEETS);\n view.setMimeTypes('application/vnd.google-apps.spreadsheet');\n view.setParent('root');\n\n const picker = new google.picker.PickerBuilder()\n .setTitle('Select a spreadsheet')\n .enableFeature(google.picker.Feature.NAV_HIDDEN)\n .setOAuthToken(accessToken)\n .addView(view)\n .setDeveloperKey(developerKey)\n .setCallback(pickerSpreadsheetCallback)\n .build();\n picker.setVisible(true);\n }\n}\n\nfunction registerClickEvents() {\n document\n .querySelector('.js-btn-spreadsheet')\n .addEventListener('click', createSpreadsheetPicker);\n document\n .querySelector('.js-btn-files')\n .addEventListener('click', createFilesPicker);\n}\n\nfunction loadAndInitGAPI() {\n return new Promise((resolve, reject) => {\n const script = document.createElement('script');\n script.type = 'text/javascript';\n script.src = 'https://apis.google.com/js/api.js';\n script.onload = (e) => {\n window.gapi.load('picker', { callback: registerClickEvents });\n };\n document.getElementsByTagName('head')[0].appendChild(script);\n });\n}\n\ndocument.addEventListener('turbolinks:load', () => {\n if (document.querySelector('.js-batch-ingest-spreadsheet')) {\n loadAndInitGAPI();\n $('.js-batch-ingest-spreadsheet').on(\n 'click',\n '.js-btn-delete-file',\n deleteSpreadsheet,\n );\n $('.js-batch-ingest-files-list').on(\n 'click',\n '.js-btn-delete-file',\n deleteFileFromFilesList,\n );\n }\n});\n"], |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
murny
force-pushed
the
webpacker-migration
branch
from
efdd0a9
to
9e8408d
Compare
This was referenced Feb 21, 2024
murny
force-pushed
the
webpacker-migration
branch
from
d108700
to
a65b0bc
Compare
|
Manually tested this some more today, precompile the assets as if it was production as well, and think this is ready to go now. Just need a re-approval. |
ConnorSheremeta
approved these changes
Feb 26, 2024
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Webpacker is deprecated/end of life now and has been a source of many CVEs for this project. This PR will migrate our JS assets to Esbuild (via jsbundling) and css/image assets back to sprockets (+ cssbundling).
This is more aligned with the recommended approach from Rails. (e.g if you generate a new Rails 7 application most likely you would use esbuild or importmaps)
Did a bunch of testing on various screens and trying all our custom JS etc and no issues.
This diff is very large, but most of it is deletion of files and package/gem lock diffs.