Add patch for VCR for fixing VCR crashing in Ruby v3.1

[murny]

Context

Our test runner appears to be crashing after running:

The issue appears to be with Ruby v3.1 and VCR: vcr/vcr#907

This was fixed in v6.1 of VCR.

Simply bumping VCR up to v6.2 fixes the problem.

HOWEVER:

We purposely locked VCR to v5.0 though. We did this because of their license change from MIT to The Hippocratic License. I believe this is still relevant?

Discussion on this from Matt:
#1667

So if we feel this is still relevant, then it appears some people offered fixes for v5.0 in vcr/vcr#907 for us that we can maybe look into adopting as an alternative.

My gut feeling, is this is still relevant. So perhaps next steps I'll work on a quick fix using one of the suggestions in the PR and push this up instead. (Like Matt said, maybe the best solution is to go to webmock instead and just drop VCR, but this is obviously out of scope for now.)

UPDATE

Created an ticket in the backlog for migrating off of VCR: #3228

The approach I took was a simple patch that runs as an initializer, if in test environment, we load VCR and monkeypatch VCR to apply the fix. This seems to work well.

[pgwillia]

Context

Our test runner appears to be crashing after running:

The issue appears to be with Ruby v3.1 and VCR: vcr/vcr#907

This was fixed in v6.1 of VCR.

Simply bumping VCR up to v6.2 fixes the problem.

HOWEVER:

We purposely locked VCR to v5.0 though. We did this because of their license change from MIT to The Hippocratic License. I believe this is still relevant?

Discussion on this from Matt: #1667

So if we feel this is still relevant, then it appears some people offered fixes for v5.0 in vcr/vcr#907 for us that we can maybe look into adopting as an alternative.

My gut feeling, is this is still relevant. So perhaps next steps I'll work on a quick fix using one of the suggestions in the PR and push this up instead. (Like Matt said, maybe the best solution is to go to webmock instead and just drop VCR, but this is obviously out of scope for now.)

I share your gut feeling that this is still relevant and trust Matt's analysis of the situation and I suspect it hasn't changed.

Please proceed with the "quick fix" initializer from the suggestions and perhaps add a ticket to the backlog (I didn't see one on a quick search).

[murny]

I share your gut feeling that this is still relevant and trust Matt's analysis of the situation and I suspect it hasn't changed.

Please proceed with the "quick fix" initializer from the suggestions and perhaps add a ticket to the backlog (I didn't see one on a quick search).

Sounds great 👍 . I'll do the quick fix and throw a new ticket in the backlog to maybe look into migrating off VCR to another gem (just use Webmock maybe might be the best course)

UPDATE: created #3228 and took the simple patch route instead

[pgwillia]