Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.16.1 to 2.19.0 #3109

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 7, 2023

Bumps rubocop-rails from 2.16.1 to 2.19.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.19.0

New features

Bug fixes

  • #934: Fix a false negative for Rails/Output when print methods without arguments. (@​koic)
  • #99: Fix a false positive for Rails/HttpPositionalArguments when using include Rack::Test::Methods. (@​koic)
  • #501: Fix a false positive for Rails/OutputSafety when using html_safe for I18n methods. (@​koic)
  • #860: Fix a false positive for Rails/Pluck when using regexp literal key for String#[]. (@​koic)
  • #938: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not.lt(condition) as a Mongoid API'. (@​koic)
  • #941: Remove redundant config for Style/InverseMethods. (@​koic)

Changes

  • #299: Add autocorrection for Rails/ReflectionClassName. (@​tejasbubane)
  • #34: Allow CreateTableWithTimestamps when using id: false and not include timestamps. (@​koic)
  • #694: Mark Rails/FindEach as unsafe. (@​koic)
  • #940: Mark Rails/ResponseParsedBody as unsafe. (@​koic)

RuboCop Rails 2.17.4

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. (@​koic)
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. (@​gurix)
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. (@​ydah)
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. (@​koic)
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. (@​etiennebarrie)
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. (@​fatkodima)

Changes

RuboCop Rails 2.17.3

% cat relnotes/v2.17.3.md

Bug fixes

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.19.0 (2023-04-07)

New features

Bug fixes

  • #934: Fix a false negative for Rails/Output when print methods without arguments. ([@​koic][])
  • #99: Fix a false positive for Rails/HttpPositionalArguments when using include Rack::Test::Methods. ([@​koic][])
  • #501: Fix a false positive for Rails/OutputSafety when using html_safe for I18n methods. ([@​koic][])
  • #860: Fix a false positive for Rails/Pluck when using regexp literal key for String#[]. ([@​koic][])
  • #938: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not.lt(condition) as a Mongoid API'. ([@​koic][])
  • #941: Remove redundant config for Style/InverseMethods. ([@​koic][])

Changes

  • #299: Add autocorrection for Rails/ReflectionClassName. ([@​tejasbubane][])
  • #34: Allow CreateTableWithTimestamps when using id: false and not include timestamps. ([@​koic][])
  • #694: Mark Rails/FindEach as unsafe. ([@​koic][])
  • #940: Mark Rails/ResponseParsedBody as unsafe. ([@​koic][])

2.18.0 (2023-02-25)

New features

Bug fixes

  • #824: Fix a false negative for Rails/ActionControllerTestCase when the class is namespaced. ([@​vlad-pisanov][])
  • #909: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash before redirect_to in if branch. ([@​koic][])
  • #898: Fix a false positive for Rails/ActiveRecordAliases when arguments of update_attributes is empty. ([@​koic][])
  • #920: Fix an error for Rails/NegateInclude when there is no receiver. ([@​fatkodima][])
  • #931: Fix error in Rails/Presence when ternary operators are used in multiple lines. ([@​r7kamura][])
  • #687: Fix Rails/HasManyOrHasOneDependent to correctly handle association methods with receiver. ([@​fatkodima][])
  • #929: Prevent Rails/SquishedSQLHeredocs applying when single-line comments are present. ([@​john-h-k][])
  • #887: Fix a false positive for Rails/NotNullColumn when adding a :virtual column. ([@​fatkodima][])
  • #918: Fix Rails/FreezeTime running against Rails < 5.2 apps. ([@​DRBragg][])
  • #895: Fix Rails/UnusedIgnoredColumns not recognizing columns added via +=. ([@​lucthev][])

Changes

  • #263: Accept actions defined via alias in Rails/LexicallyScopedActionFilter. ([@​fatkodima][])
  • #902: Ignore redirect method for Style/FormatStringToken by default. ([@​javierjulio][])
  • #935: Make Style/InverseMethods aware of Active Support's present?, blank?, include?, and exclude? methods. ([@​koic][])
  • #914: Make Style/InverseMethods aware of valid? and invalid? methods. ([@​koic][])
  • #826: Mark Rails/Pluck as unsafe. ([@​fatkodima][])
  • #896: Raise severity of Rails/ActiveRecordOverride, Rails/DeprecatedActiveModelErrorsMethods, Rails/DuplicateAssociation, Rails/DuplicateScope, Rails/TopLevelHashWithIndifferentAccess, and Rails/WhereNotWithMultipleConditions cops to warning. ([@​koic][])

... (truncated)

Commits
  • 02b06d9 Cut 2.19.0
  • d636e3a Update Changelog
  • a955422 Merge pull request #976 from koic/fix_a_false_positive_for_rails_output_safety
  • 1d59a6d Merge pull request #975 from koic/allow_create_table_with_timestamps_for_id_f...
  • 26872d6 Merge pull request #974 from koic/make_rails_delegate_aware_of_self
  • c7d8b3e Use each_comment_in_lines instead of deprecated API
  • 935ae8e Remove Style/InverseMethods config for exists?
  • f73d8ed Merge pull request #973 from koic/make_style_inverse_methods_aware_of_exists_...
  • 9ac7a15 Merge pull request #972 from koic/mark_rails_find_each_as_unsafe
  • ce3abde Merge pull request #971 from koic/mark_rails_response_parsed_body_as_unsafe
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Apr 7, 2023
@pgwillia pgwillia force-pushed the dependabot/bundler/master/rubocop-rails-2.19.0 branch from c3010dc to 23bd9a3 Compare April 12, 2023 19:35
dependabot bot and others added 5 commits April 12, 2023 13:37
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.16.1 to 2.19.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.16.1...v2.19.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Action edit should appear before create.
Unnecessary enabling of Rails/OutputSafety.
  # rubocop:enable Rails/OutputSafety
Rails/ResponseParsedBody: Prefer response.parsed_body to JSON.parse(response.body).

Rails/Pluck: Prefer pluck('id') over map { |result| result['id'] }. (https://rails.rubystyle.guide#pluck)
@pgwillia pgwillia force-pushed the dependabot/bundler/master/rubocop-rails-2.19.0 branch from 23bd9a3 to ce871db Compare April 12, 2023 19:38
@pgwillia pgwillia merged commit d45a4c1 into master Apr 12, 2023
@pgwillia pgwillia deleted the dependabot/bundler/master/rubocop-rails-2.19.0 branch April 12, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant