Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump simplecov from 0.21.2 to 0.22.0 #3063

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 7, 2023

Bumps simplecov from 0.21.2 to 0.22.0.

Changelog

Sourced from simplecov's changelog.

0.22.0 (2022-12-23)

Enhancements

Bugfixes

Commits
  • 0e35b25 Add missing closing parenthesis)
  • 8117802 Merge pull request #1041 from simplecov-ruby/co-prepare-0.22.0
  • 26407f1 Hmm, ok maybe I actually have to bump the version here as well
  • 8fdc6b9 Run bundle lock in each test project directory
  • 7f44498 Go back to prior bundler and json formatter versions, to make CI happy
  • 761956b Bump to latest bundler version for development
  • 8f3be99 Bump version, update changelog
  • 43f0e39 Merge pull request #1034 from nhtruong/main
  • 6bc65b0 Merge pull request #1037 from mame/coverage-for-eval
  • 56ca3f5 Show a warning for the case where coverage for eval is unavailable
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Feb 7, 2023
@dependabot dependabot bot force-pushed the dependabot/bundler/master/simplecov-0.22.0 branch 2 times, most recently from fe37920 to 77d02fb Compare February 13, 2023 20:55
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov) from 0.21.2 to 0.22.0.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases)
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md)
- [Commits](simplecov-ruby/simplecov@v0.21.2...v0.22.0)

---
updated-dependencies:
- dependency-name: simplecov
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/master/simplecov-0.22.0 branch from 77d02fb to cd940d6 Compare February 13, 2023 21:28
@pgwillia pgwillia self-assigned this Feb 13, 2023
@pgwillia
Copy link
Member

Noticed that we have less that 2% coverage. Seems fishy. Going to investigate.

@pgwillia
Copy link
Member

I discovered that using rails test reports unrealistically low coverage while using rake test seems correct. Furthermore, I found that using DISABLE_SPRING=true rails test will say the same as the rake test in terms of coverage. I'll add this to our GitHub actions.

I noticed that `rails test` was reporting low coverage (1.46%).  I tried a number of things in the SimpleCov readme without success.  In the process I did discovery that `rake test` was reporting reasonable coverage (82.06%). This lead me to reread the DISABLE_SPRING env var suggestion in the SimpleCov readme which did the trick.  Spring keeps your Rails application preloaded so you don't need to boot it everytime you test, etc.  Not necessary in CI and interferes with SimpleCov which requires that it's loaded before anything else.
@pgwillia pgwillia force-pushed the dependabot/bundler/master/simplecov-0.22.0 branch from 83201b7 to 0440ff6 Compare February 14, 2023 00:05
@pgwillia pgwillia merged commit 153669c into master Feb 14, 2023
@pgwillia pgwillia deleted the dependabot/bundler/master/simplecov-0.22.0 branch February 14, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant